Issue 23005027: Factor out HSimulate::ReplayEnvironment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23005027: Factor out HSimulate::ReplayEnvironment. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Factor out HSimulate::ReplayEnvironment. R=titzer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16340

Patch Set 2 : Addressed commment by Ben Titzer. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -64 lines)			Patch
M	src/arm/lithium-arm.cc	View	1	2 chunks	+2 lines, -16 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1	2 chunks	+2 lines, -16 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1	2 chunks	+2 lines, -16 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	2 chunks	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

titzer

lgtm https://codereview.chromium.org/23005027/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): https://codereview.chromium.org/23005027/diff/1/src/ia32/lithium-ia32.cc#newcode2619 src/ia32/lithium-ia32.cc:2619: instr->ReplayEnvironment(env); Inline the local too...make it a one ...

7 years, 3 months ago (2013-08-26 16:49:44 UTC) #2

Michael Starzinger

Addressed comments. Landing. https://codereview.chromium.org/23005027/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): https://codereview.chromium.org/23005027/diff/1/src/ia32/lithium-ia32.cc#newcode2619 src/ia32/lithium-ia32.cc:2619: instr->ReplayEnvironment(env); On 2013/08/26 16:49:44, titzer wrote: ...

7 years, 3 months ago (2013-08-26 17:29:46 UTC) #3

Michael Starzinger

7 years, 3 months ago (2013-08-26 17:30:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16340 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23005027: Factor out HSimulate::ReplayEnvironment. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed commment by Ben Titzer. #

Messages