tools/testing/dart/browser_controller.dart - Issue 23005022: Catch race condition where we are shutting down a browser and that browser is sending back results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 23005022: Catch race condition where we are shutting down a browser and that browser is sending back results. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/browser_controller.dart

===================================================================

--- tools/testing/dart/browser_controller.dart (revision 26512)

+++ tools/testing/dart/browser_controller.dart (working copy)

@@ -654,9 +654,9 @@

return;

}

- if (status.timeout) {

+ if (status == null || status.timeout) {

// We don't do anything, this browser is currently being killed and

- // replaced.

+ // replaced. The browser here can be null if we decided to kill the browser

kustermann 2013/08/22 16:30:44 Yes, Yes: Long line rico!

} else if (status.currentTest != null) {

status.currentTest.timeoutTimer.cancel();

status.currentTest.stopwatch.stop();

« no previous file with comments | « no previous file | no next file » | no next file with comments »