[sync] Force re-auth during sync setup if Oauth2 token is unavailable

chrome/browser/signin/profile_oauth2_token_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/profile_oauth2_token_service.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/stl_util.h"
 #include "base/time/time.h"
@@ skipping 134 matching lines @@
       break;
     }
     case chrome::NOTIFICATION_TOKENS_CLEARED: {
       CancelAllRequests();
       ClearCache();
       UpdateAuthError(GoogleServiceAuthError::AuthErrorNone());
       FireRefreshTokensCleared();
       break;
     }
     case chrome::NOTIFICATION_TOKEN_LOADING_FINISHED:
+      // During startup, if the OAuth2 refresh token is empty, flag it as an
+      // error by badging the menu. Otherwise, if a signed in user tries to set
+      // up sync, they will have to make two attempts: One to surface the OAuth2
+      // error, and a second one after they've signed in. See crbug.com/276650.
+      if (GetRefreshToken().empty()) {

[Andrew T Wilson (Slow), 2013/08/22 10:29:09]

I think we probably only want to do this if the user is signed in (if
GetAccountId() returns a non-empty string)?

[Raghu Simha, 2013/08/22 17:48:50]

From what I've seen, we enter this observer only when the user is signed in.
Having said that, I agree that it's good to check if the user is signed in
before badging the menu. Done.

+        UpdateAuthError(GoogleServiceAuthError(
+            GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS));
+      }
       FireRefreshTokensLoaded();
       break;
     default:
       NOTREACHED() << "Invalid notification type=" << type;
       break;
   }
 }
 
 GoogleServiceAuthError ProfileOAuth2TokenService::GetAuthStatus() const {
   return last_auth_error_;
@@ skipping 150 matching lines @@
     }
   }
 
   if (!old_login_token.empty() &&
       refresh_tokens_.count(GetAccountId(profile_)) == 0) {
     UpdateCredentials(GetAccountId(profile_), old_login_token);
   }
 
   FireRefreshTokensLoaded();
 }