Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 23005010: Drop [LegacyImplementedInBaseClass] from ParentNode interface (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use
Visibility:
Public.

Description

Drop [LegacyImplementedInBaseClass] from ParentNode interface Drop [LegacyImplementedInBaseClass] from ParentNode interface and add functions in ParentNode namespace to forward calls to the ContainerNode class. R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156305

Patch Set 1 #

Patch Set 2 : Fix build issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M Source/core/core.gypi View 1 3 chunks +2 lines, -1 line 0 comments Download
A + Source/core/dom/ParentNode.h View 1 2 chunks +25 lines, -14 lines 0 comments Download
M Source/core/dom/ParentNode.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-19 10:52:37 UTC) #1
haraken
LGTM
7 years, 4 months ago (2013-08-19 11:14:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23005010/4001
7 years, 4 months ago (2013-08-19 11:17:43 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-19 12:30:40 UTC) #4
Message was sent while issue was closed.
Change committed as 156305

Powered by Google App Engine
This is Rietveld 408576698