native_client_sdk/src/libraries/nacl_io/ioctl.h - Issue 23005005: [NaCl SDK] nacl_io: Add initial implementations of kill and signal

Side by Side Diff: native_client_sdk/src/libraries/nacl_io/ioctl.h

Issue 23005005: [NaCl SDK] nacl_io: Add initial implementations of kill and signal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/include/sys/ioctl.h ('k') | native_client_sdk/src/libraries/nacl_io/kernel_intercept.h » ('j') | native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /* Copyright 2013 The Chromium Authors. All rights reserved.	1 /* Copyright 2013 The Chromium Authors. All rights reserved.

2 * Use of this source code is governed by a BSD-style license that can be	2 * Use of this source code is governed by a BSD-style license that can be

3 * found in the LICENSE file. */	3 * found in the LICENSE file. */

4	4

5 #ifndef LIBRARIES_NACL_IO_IOCTL_H_	5 #ifndef LIBRARIES_NACL_IO_IOCTL_H_

6 #define LIBRARIES_NACL_IO_IOCTL_H_	6 #define LIBRARIES_NACL_IO_IOCTL_H_

7	7

8 /* ioctl to tell a tty mount to prefix every message with a particular	8 /*

9 * null-terminated string. Accepts a pointer to a C string which will	9 * ioctl to feed input to a tty node. Accepts a pointer to the following

10 * be the prefix.

11 */

12 #define TIOCNACLPREFIX 0xadcd01

13

14 /* ioctl to feed input to a tty mount. Accepts a pointer to the following

15 * struct (tioc_nacl_input_string), which contains a pointer to an array	10 * struct (tioc_nacl_input_string), which contains a pointer to an array

16 * of characters.	11 * of characters.

17 */	12 */

18 #define TIOCNACLINPUT 0xadcd02	13 #define TIOCNACLINPUT 0xadcd02

19	14

	15 /*

	16 * ioctl to register an output handler with the tty node. Will fail

	17 * with EALREADY if a handler is already registered. Call with NULL
	binji 2013/08/22 18:09:36 Why fail if already set? It could just overwrite i Why fail if already set? It could just overwrite it. Sam Clegg 2013/08/22 19:52:25 Just so the user knows when they do that. Its pro Show quoted text On 2013/08/22 18:09:36, binji wrote: > Why fail if already set? It could just overwrite it. Just so the user knows when they do that. Its probably a coding error to do this.
	18 * to unregister handler.
	binji 2013/08/22 18:09:36 document the thread that gets the callback: the th document the thread that gets the callback: the thread that writes to the tty node. Sam Clegg 2013/08/22 19:52:25 Done. Show quoted text On 2013/08/22 18:09:36, binji wrote: > document the thread that gets the callback: the thread that writes to the tty > node. Done.
	19 */

	20 #define TIOCNACLOUTPUT 0xadcd03

	21

20 struct tioc_nacl_input_string {	22 struct tioc_nacl_input_string {

21 size_t length;	23 size_t length;

22 const char* buffer;	24 const char* buffer;

23 };	25 };

24	26

	27

	28 typedef int (nacl_io_tty_output_handler_t)(const char buf, int count);
	binji 2013/08/22 18:09:36 size_t for consistency with tioc_nacl_input_tstrin size_t for consistency with tioc_nacl_input_tstring binji 2013/08/22 18:09:36 tioc prefix? tioc prefix? binji 2013/08/22 18:09:36 document that the return value is the number of by document that the return value is the number of bytes written. binji 2013/08/22 18:09:36 Make this a struct containing the function pointer Make this a struct containing the function pointer and user_data? Sam Clegg 2013/08/22 19:52:25 Done. Show quoted text On 2013/08/22 18:09:36, binji wrote: > size_t for consistency with tioc_nacl_input_tstring Done. Sam Clegg 2013/08/22 19:52:25 Done. Show quoted text On 2013/08/22 18:09:36, binji wrote: > tioc prefix? Done. Sam Clegg 2013/08/22 19:52:25 Done. Show quoted text On 2013/08/22 18:09:36, binji wrote: > document that the return value is the number of bytes written. Done. Sam Clegg 2013/08/22 19:52:25 Done. Show quoted text On 2013/08/22 18:09:36, binji wrote: > Make this a struct containing the function pointer and user_data? Done.
	29

	30

25 #endif /* LIBRARIES_NACL_IO_NACL_IO_H_ */	31 #endif /* LIBRARIES_NACL_IO_NACL_IO_H_ */

OLD	NEW