Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2612)

Unified Diff: blimp/client/core/blimp_client_context_impl.cc

Issue 2300493002: Move glue code of blob channel to blimp_client_context_impl. (Closed)
Patch Set: More polish on comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/blimp_client_context_impl.cc
diff --git a/blimp/client/core/blimp_client_context_impl.cc b/blimp/client/core/blimp_client_context_impl.cc
index 75ab73c39e9adbf027ad76741b8724d73f87642f..c2eca2a1d377644a76f0de90f9252b77786de5e8 100644
--- a/blimp/client/core/blimp_client_context_impl.cc
+++ b/blimp/client/core/blimp_client_context_impl.cc
@@ -11,6 +11,7 @@
#include "base/threading/sequenced_task_runner_handle.h"
#include "blimp/client/core/blimp_client_switches.h"
#include "blimp/client/core/compositor/blimp_compositor_dependencies.h"
+#include "blimp/client/core/compositor/blob_manager.h"
#include "blimp/client/core/contents/blimp_contents_impl.h"
#include "blimp/client/core/contents/blimp_contents_manager.h"
#include "blimp/client/core/contents/ime_feature.h"
@@ -65,6 +66,7 @@ BlimpClientContextImpl::BlimpClientContextImpl(
blimp_compositor_dependencies_(
base::MakeUnique<BlimpCompositorDependencies>(
std::move(compositor_dependencies))),
+ blob_manager_(new BlobManager(this)),
ime_feature_(new ImeFeature),
navigation_feature_(new NavigationFeature),
render_widget_feature_(new RenderWidgetFeature),
@@ -174,6 +176,8 @@ void BlimpClientContextImpl::ConnectWithAssignment(
void BlimpClientContextImpl::RegisterFeatures() {
// Register features' message senders and receivers.
+ thread_pipe_manager_->RegisterFeature(BlimpMessage::kBlobChannel,
+ blob_manager_.get());
ime_feature_->set_outgoing_message_processor(
thread_pipe_manager_->RegisterFeature(BlimpMessage::kIme,
ime_feature_.get()));
@@ -208,5 +212,13 @@ void BlimpClientContextImpl::CreateIdentitySource() {
base::Unretained(this)));
}
+void BlimpClientContextImpl::OnImageDecodeError() {
+ io_thread_task_runner_->PostTask(
David Trainor- moved to gerrit 2016/09/02 00:56:47 Can you add a comment that we're currently just dr
xingliu 2016/09/02 02:13:40 Done.
+ FROM_HERE,
+ base::Bind(
+ &BrowserConnectionHandler::DropCurrentConnection,
+ base::Unretained(net_components_->GetBrowserConnectionHandler())));
+}
+
} // namespace client
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698