Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2300463002: Add observers for DIP scale change. (Closed)
Patch Set: Update the fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 7854c3e44ecb2dd4432142a395239ddef0b483d0..9913e63635e07cf48fe0b3205b1212f4c63900af 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -209,13 +209,14 @@ ContentViewCoreImpl::ContentViewCoreImpl(
WebContents* web_contents,
const JavaRef<jobject>& view_android_delegate,
ui::WindowAndroid* window_android,
+ float dpi_scale,
Ted C 2016/10/31 20:02:40 since we're here, is this supposed to be dpi or di
Tima Vaisburd 2016/10/31 20:37:59 I wanted it to be dip (for Device Independent Pixe
Ted C 2016/11/01 17:07:16 Hmm...it does seem to be used all over this class
Tima Vaisburd 2016/11/01 18:23:26 Let's have a followup!
const JavaRef<jobject>& java_bridge_retained_object_set)
: WebContentsObserver(web_contents),
java_ref_(env, obj),
view_(view_android_delegate),
web_contents_(static_cast<WebContentsImpl*>(web_contents)),
page_scale_(1),
- dpi_scale_(ui::GetScaleFactorForNativeView(&view_)),
+ dpi_scale_(dpi_scale),
device_orientation_(0),
accessibility_enabled_(false) {
CHECK(web_contents) <<
@@ -803,6 +804,15 @@ float ContentViewCoreImpl::GetBottomControlsHeightDip() const {
return GetBottomControlsHeightPix() / dpi_scale();
}
+void ContentViewCoreImpl::SendScreenRectsAndResizeWidget() {
+ RenderWidgetHostViewAndroid* view = GetRenderWidgetHostViewAndroid();
+ if (view) {
+ // |SendScreenRects()| indirectly calls GetViewSize() that asks Java layer.
+ web_contents_->SendScreenRects();
+ view->WasResized();
+ }
+}
+
void ContentViewCoreImpl::MoveRangeSelectionExtent(const gfx::PointF& extent) {
if (!web_contents_)
return;
@@ -868,6 +878,16 @@ void ContentViewCoreImpl::SetFocus(JNIEnv* env,
SetFocusInternal(focused);
}
+void ContentViewCoreImpl::SetDIPScale(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jfloat dpi_scale) {
+ if (dpi_scale_ == dpi_scale)
+ return;
+
+ dpi_scale_ = dpi_scale;
+ SendScreenRectsAndResizeWidget();
+}
+
void ContentViewCoreImpl::SetFocusInternal(bool focused) {
if (!GetRenderWidgetHostViewAndroid())
return;
@@ -1236,16 +1256,12 @@ void ContentViewCoreImpl::RemoveJavascriptInterface(
void ContentViewCoreImpl::WasResized(JNIEnv* env,
const JavaParamRef<jobject>& obj) {
- RenderWidgetHostViewAndroid* view = GetRenderWidgetHostViewAndroid();
gfx::Size physical_size(
Java_ContentViewCore_getPhysicalBackingWidthPix(env, obj),
Java_ContentViewCore_getPhysicalBackingHeightPix(env, obj));
view_.GetLayer()->SetBounds(physical_size);
- if (view) {
- web_contents_->SendScreenRects();
- view->WasResized();
- }
+ SendScreenRectsAndResizeWidget();
}
long ContentViewCoreImpl::GetNativeImeAdapter(
@@ -1555,11 +1571,12 @@ jlong Init(JNIEnv* env,
const JavaParamRef<jobject>& web_contents,
const JavaParamRef<jobject>& view_android_delegate,
jlong window_android,
+ jfloat dipScale,
const JavaParamRef<jobject>& retained_objects_set) {
ContentViewCoreImpl* view = new ContentViewCoreImpl(
env, obj, WebContents::FromJavaWebContents(web_contents),
view_android_delegate,
- reinterpret_cast<ui::WindowAndroid*>(window_android),
+ reinterpret_cast<ui::WindowAndroid*>(window_android), dipScale,
retained_objects_set);
return reinterpret_cast<intptr_t>(view);
}

Powered by Google App Engine
This is Rietveld 408576698