[Extensions] Begin making Extension port initialization asynchronous

extensions/renderer/resources/messaging.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // chrome.runtime.messaging API implementation.
 // TODO(robwu): Fix this indentation.
 
   // TODO(kalman): factor requiring chrome out of here.
   var chrome = requireNative('chrome').GetChrome();
   var Event = require('event_bindings').Event;
   var lastError = require('lastError');
   var logActivity = requireNative('activityLogger');
   var logging = requireNative('logging');
   var messagingNatives = requireNative('messaging_natives');
   var processNatives = requireNative('process');
   var utils = require('utils');
   var messagingUtils = require('messaging_utils');
 
   // The reserved channel name for the sendRequest/send(Native)Message APIs.
   // Note: sendRequest is deprecated.
   var kRequestChannel = "chrome.extension.sendRequest";
   var kMessageChannel = "chrome.runtime.sendMessage";
   var kNativeMessageChannel = "chrome.runtime.sendNativeMessage";
   var kPortClosedError = 'Attempting to use a disconnected port object';
 
   // Map of port IDs to port object.
   var ports = {__proto__: null};
 
-  // Change even to odd and vice versa, to get the other side of a given
-  // channel.
-  function getOppositePortId(portId) { return portId ^ 1; }
-
   // Port object.  Represents a connection to another script context through
   // which messages can be passed.
   function PortImpl(portId, opt_name) {
     this.portId_ = portId;
     this.name = opt_name;
 
     // Note: Keep these schemas in sync with the documentation in runtime.json
     var portSchema = {
       __proto__: null,
       name: 'port',
@@ skipping 54 matching lines @@
     messagingNatives.CloseChannel(this.portId_, false);
     this.destroy_();
   };
 
   PortImpl.prototype.destroy_ = function() {
     privates(this.onDisconnect).impl.destroy_();
     privates(this.onMessage).impl.destroy_();
     delete ports[this.portId_];
   };
 
-  // Returns true if the specified port id is in this context. This is used by
-  // the C++ to avoid creating the javascript message for all the contexts that
-  // don't care about a particular message.
-  function hasPort(portId) {
-    return $Object.hasOwnProperty(ports, portId);
-  };
-
   // Hidden port creation function.  We don't want to expose an API that lets
   // people add arbitrary port IDs to the port list.
   function createPort(portId, opt_name) {
     if (ports[portId])
       throw new Error("Port '" + portId + "' already exists.");
     var port = new Port(portId, opt_name);
     ports[portId] = port;
     return port;
   };
 
@@ skipping 118 matching lines @@
     // Only create a new Port if someone is actually listening for a connection.
     // In addition to being an optimization, this also fixes a bug where if 2
     // channels were opened to and from the same process, closing one would
     // close both.
     var extensionId = processNatives.GetExtensionId();
 
     // messaging_bindings.cc should ensure that this method only gets called for
     // the right extension.
     logging.CHECK(targetExtensionId == extensionId);
 
-    if (ports[getOppositePortId(portId)])
-      return false;  // this channel was opened by us, so ignore it
-
     // Determine whether this is coming from another extension, so we can use
     // the right event.
     var isExternal = sourceExtensionId != extensionId;
 
     var sender = {};
     if (sourceExtensionId != '')
       sender.id = sourceExtensionId;
     if (sourceUrl)
       sender.url = sourceUrl;
     if (sourceTab)
@@ skipping 162 matching lines @@
 
 exports.$set('kRequestChannel', kRequestChannel);
 exports.$set('kMessageChannel', kMessageChannel);
 exports.$set('kNativeMessageChannel', kNativeMessageChannel);
 exports.$set('Port', Port);
 exports.$set('createPort', createPort);
 exports.$set('sendMessageImpl', sendMessageImpl);
 exports.$set('sendMessageUpdateArguments', sendMessageUpdateArguments);
 
 // For C++ code to call.
-exports.$set('hasPort', hasPort);
 exports.$set('dispatchOnConnect', dispatchOnConnect);
 exports.$set('dispatchOnDisconnect', dispatchOnDisconnect);
 exports.$set('dispatchOnMessage', dispatchOnMessage);