Issue 2300433003: gclient_utils: provide subproces42 based CheckCallAndFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2300433003: gclient_utils: provide subproces42 based CheckCallAndFilter. (Closed)

Created:
4 years, 3 months ago by tandrii(chromium)

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

gclient_utils: provide subproces42 based CheckCallAndFilter. BUG=635641

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -1 line)			Patch
	M	gclient_utils.py	View		5 chunks	+106 lines, -1 line	0 comments	Download
	M	tests/gclient_utils_test.py	View		4 chunks	+90 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Issue 2300633002 Patch 1

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tandrii(chromium)

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

4 years, 3 months ago (2016-08-31 13:51:27 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300433003/1

4 years, 3 months ago (2016-08-31 13:51:30 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 3 months ago (2016-08-31 13:57:19 UTC) #3

commit-bot: I haz the power

4 years, 3 months ago (2016-08-31 13:57:20 UTC) #4

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30f9b2e195967d10)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages