third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js - Issue 2300403003: DevTools: patch browser's Chrome version into Chrome user agents for emulation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js

Issue 2300403003: DevTools: patch browser's Chrome version into Chrome user agents for emulation (Closed)

Patch Set: address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js » ('j') | third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js b/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js

index 7369d659813e05f41259b32b99b7f3dacae5fbe6..3e9585a65112186acdd8b4dd49e5e84f66825cfd 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js

@@ -140,6 +140,7 @@ WebInspector.EmulatedDevice.fromJSONV1 = function(json)

result.title = /** @type {string} */ (parseValue(json, "title", "string"));

result.type = /** @type {string} */ (parseValue(json, "type", "string"));

result.userAgent = /** @type {string} */ (parseValue(json, "user-agent", "string"));

pfeldman 2016/09/15 21:44:07 use intermediate variable.

luoe 2016/09/15 23:18:08 Done.

+ result.userAgent = WebInspector.BrowserVersionInfo.patchUserAgentWithChromeVersion(result.userAgent);

var capabilities = parseValue(json, "capabilities", "object", []);

if (!Array.isArray(capabilities))