DevTools: patch browser's Chrome version into Chrome user agents for emulation

third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  */
 WebInspector.NetworkConfigView = function()
 {
@@ skipping 79 matching lines @@
  * @return {{select: !Element, input: !Element}}
  */
 WebInspector.NetworkConfigView.createUserAgentSelectAndInput = function()
 {
     var userAgentSetting = WebInspector.settings.createSetting("customUserAgent", "");
     var userAgentSelectElement = createElement("select");
 
     const customOverride = {title: WebInspector.UIString("Custom..."), value: "custom"};
     userAgentSelectElement.appendChild(new Option(customOverride.title, customOverride.value));
 
-    var groups = WebInspector.NetworkConfigView._userAgentGroups;
-    for (var userAgentDescriptor of WebInspector.NetworkConfigView._userAgentGroups) {
+    var groups = WebInspector.NetworkConfigView.UserAgentGroups();
+    for (var userAgentDescriptor of groups) {
         var groupElement = userAgentSelectElement.createChild("optgroup");
         groupElement.label = userAgentDescriptor.title;
         for (var userAgentVersion of userAgentDescriptor.values)
             groupElement.appendChild(new Option(userAgentVersion.title, userAgentVersion.value));

[dgozman, 2016/09/07 22:06:28]

Why not patch right here with a single call?

[luoe, 2016/09/07 22:46:32]

I think it makes a readable, self-contained unit that can be reused if we ever
want to iterate through UserAgentGroups() in other places.  However, we're only
using it on creation, so I'm fine with moving it here.

     }
 
     userAgentSelectElement.selectedIndex = 0;
 
     var otherUserAgentElement = createElement("input");
     otherUserAgentElement.type = "text";
     otherUserAgentElement.value = userAgentSetting.get();
     otherUserAgentElement.title = userAgentSetting.get();
     otherUserAgentElement.placeholder = WebInspector.UIString("Enter a custom user agent");
     otherUserAgentElement.required = true;
@@ skipping 36 matching lines @@
         if (userAgentSetting.get() !== otherUserAgentElement.value) {
             userAgentSetting.set(otherUserAgentElement.value);
             otherUserAgentElement.title = otherUserAgentElement.value;
             settingChanged();
         }
     }
 
     return { select: userAgentSelectElement, input: otherUserAgentElement };
 }
 
+/**
+ * @return {!Array.<{title: string, values: !Array.<{title: string, value: string}>}>}
+ */
+WebInspector.NetworkConfigView.UserAgentGroups = function()
+{
+    return WebInspector.NetworkConfigView._userAgentGroups.map(patchGroups);
+
+    /**
+     * @param {!Object.<string, !Array.<{title: string, value: string}>>} group
+     * @return {!Object.<string, !Array.<{title: string, value: string}>>}
+     */
+    function patchGroups(group)
+    {
+        if (group.title !== "Chrome")
+            return group;
+
+        for (var i = 0; i < group.values.length; i++)
+            group.values[i].value = WebInspector.BrowserVersionInfo.patchUserAgentWithCurrentVersion(group.values[i].value);
+        return group;
+    }
+}
 
 /** @type {!Array.<{title: string, values: !Array.<{title: string, value: string}>}>} */
 WebInspector.NetworkConfigView._userAgentGroups = [
     {
         title: "Android",
         values: [
             {title: "Android (4.0.2) Browser \u2014 Galaxy Nexus", value: "Mozilla/5.0 (Linux; U; Android 4.0.2; en-us; Galaxy Nexus Build/ICL53F) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30"},
             {title: "Android (2.3) Browser \u2014 Nexus S", value: "Mozilla/5.0 (Linux; U; Android 2.3.6; en-us; Nexus S Build/GRK39F) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Mobile Safari/533.1"}
         ]
     },
     {
         title: "BlackBerry",
         values: [
             {title: "BlackBerry \u2014 BB10", value: "Mozilla/5.0 (BB10; Touch) AppleWebKit/537.1+ (KHTML, like Gecko) Version/10.0.0.1337 Mobile Safari/537.1+"},
             {title: "BlackBerry \u2014 PlayBook 2.1", value: "Mozilla/5.0 (PlayBook; U; RIM Tablet OS 2.1.0; en-US) AppleWebKit/536.2+ (KHTML, like Gecko) Version/7.2.1.0 Safari/536.2+"},
             {title: "BlackBerry \u2014 9900", value: "Mozilla/5.0 (BlackBerry; U; BlackBerry 9900; en-US) AppleWebKit/534.11+ (KHTML, like Gecko) Version/7.0.0.187 Mobile Safari/534.11+"}
         ]
     },
     {
         title: "Chrome",
         values: [
-            {title: "Chrome 52 \u2014 Android Mobile", value: "Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2725.0 Mobile Safari/537.36"},
-            {title: "Chrome 52 \u2014 Android Tablet", value: "Mozilla/5.0 (Linux; Android 4.3; Nexus 7 Build/JSS15Q) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2725.0 Safari/537.36"},
-            {title: "Chrome 52 \u2014 iPhone", value: "Mozilla/5.0 (iPhone; CPU iPhone OS 9_1 like Mac OS X) AppleWebKit/601.1 (KHTML, like Gecko) CriOS/52.0.2725.0 Mobile/13B143 Safari/601.1.46"},
-            {title: "Chrome 52 \u2014 iPad", value: "Mozilla/5.0 (iPad; CPU OS 9_1 like Mac OS X) AppleWebKit/601.1 (KHTML, like Gecko) CriOS/52.0.2725.0 Mobile/13B143 Safari/601.1.46"},
-            {title: "Chrome 52 \u2014 Mac", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2725.0 Safari/537.36"},
-            {title: "Chrome 52 \u2014 Windows", value: "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2725.0 Safari/537.36"}
+            {title: "Chrome \u2014 Android Mobile", value: "Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/%s Mobile Safari/537.36"},
+            {title: "Chrome \u2014 Android Tablet", value: "Mozilla/5.0 (Linux; Android 4.3; Nexus 7 Build/JSS15Q) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/%s Safari/537.36"},
+            {title: "Chrome \u2014 iPhone", value: "Mozilla/5.0 (iPhone; CPU iPhone OS 9_1 like Mac OS X) AppleWebKit/601.1 (KHTML, like Gecko) CriOS/%s Mobile/13B143 Safari/601.1.46"},
+            {title: "Chrome \u2014 iPad", value: "Mozilla/5.0 (iPad; CPU OS 9_1 like Mac OS X) AppleWebKit/601.1 (KHTML, like Gecko) CriOS/%s Mobile/13B143 Safari/601.1.46"},
+            {title: "Chrome \u2014 Mac", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/%s Safari/537.36"},
+            {title: "Chrome \u2014 Windows", value: "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/%s Safari/537.36"}
         ]
     },
     {
         title: "Edge",
         values: [
             {title: "Edge \u2014 Windows", value: "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.10240"},
             {title: "Edge \u2014 Mobile", value: "Mozilla/5.0 (Windows Phone 10.0; Android 4.2.1; Microsoft; Lumia 640 XL LTE) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Mobile Safari/537.36 Edge/12.10166"},
             {title: "Edge \u2014 XBox", value: "Mozilla/5.0 (Windows NT 10.0; Win64; x64; Xbox; Xbox One) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/13.10586"}
         ]
     },
@@ skipping 38 matching lines @@
     },
     {
         title: "Safari",
         values: [
             {title: "Safari \u2014 iPad iOS 9", value: "Mozilla/5.0 (iPad; CPU OS 9_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13B137 Safari/601.1"},
             {title: "Safari \u2014 iPhone iOS 9", value: "Mozilla/5.0 (iPhone; CPU iPhone OS 9_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13B137 Safari/601.1"},
             {title: "Safari \u2014 Mac", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.75.14 (KHTML, like Gecko) Version/7.0.3 Safari/7046A194A"}
         ]
     }
 ]