DevTools: patch browser's Chrome version into Chrome user agents for emulation

third_party/WebKit/Source/devtools/front_end/common/BrowserVersionInfo.js

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+WebInspector.BrowserVersionInfo = {
+    /**
+     * @param {string} uaString
+     * @param {string} sectionName
+     * @return {string}
+     */
+    patchUserAgentWithCurrentVersion: function(uaString, sectionName)
+    {
+        var currentVersion = WebInspector.BrowserVersionInfo._getVersion(sectionName);
+        if (!currentVersion || !sectionName)
+            return uaString;
+
+        var sectionRegex = new RegExp("((?:^|[^\\w])" + sectionName + "/)([^\\s]+)");
+        return uaString.replace(sectionRegex, "$1" + currentVersion);

[allada, 2016/09/02 18:16:25]

Lets not use a regex replace for this, lets use: return 

String.sprintf(uaString, currentVersion);

And change WebInspector.NetworkConfigView._userAgentGroups like this:

{title: "Chrome \u2014 Android Mobile", value: "Mozilla/5.0 (Linux; Android 6.0;
Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/%s Mobile
Safari/537.36"}

It looks like String.sprintf() is safe if not all params are present in string
(ie: no %s in format string).

[allada, 2016/09/02 18:16:25]

How are we handling cases where the user wants to emulate a specific version of
chrome and puts the version in as a custom string? I assume user input values we
do not want to alter? Maybe allow the user to use %s to substitute the chrome
version?... maybe not?

[luoe, 2016/09/02 20:43:10]

Okay, it now uses %s in the strings, as it's more explicit what we're replacing.

[luoe, 2016/09/02 20:43:10]

Maybe not in this CL :)

+    },
+
+    /**
+     * @param {string} sectionName
+     * @return {?string}
+     */
+    _getVersion: function(sectionName)
+    {
+        // Extracts a version string from navigator.userAgent
+        // e.g. _getVersion("Chrome") === "1.2.3.4" when user agent is: "Chrome/1.2.3.4"
+        if (!sectionName || sectionName.indexOf("/") !== -1)
+            return null;
+        var userAgent = navigator.userAgent;
+        var sectionRegex = new RegExp("(?:^|[^\\w])" + sectionName + "/([^\\s]+)");
+        var sectionMatch = userAgent.match(sectionRegex);
+        if (sectionMatch.length < 2)
+            return null;
+        return sectionMatch[1];
+    }
+};