Issue 23004022: Rollback of r16286 in trunk branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23004022: Rollback of r16286 in trunk branch. (Closed)

Created:
7 years, 3 months ago by rossberg

Modified:
7 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/trunk

Visibility:
Public.

Rollback of r16286 in trunk branch. Fix scoping of function declarations in eval inside non-trivial local scope BUG=v8:2594 R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16325

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -156 lines)			Patch
M	src/parser.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/parser.cc	View	4 chunks	+3 lines, -34 lines	0 comments	Download
M	src/scopes.cc	View	1 chunk	+10 lines, -16 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	test/mjsunit/regress/regress-2594.js	View	1 chunk	+0 lines, -104 lines	0 comments	Download

Total messages: 3 (0 generated)

rossberg

7 years, 3 months ago (2013-08-26 13:05:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16325 (presubmit successful).