Issue 23004021: Add WebRTC .isolate files to Android build config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23004021: Add WebRTC .isolate files to Android build config (Closed)

Created:
7 years, 3 months ago by kjellander_chromium

Modified:
7 years, 3 months ago

Reviewers:
craigdh, frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, hellner1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add WebRTC .isolate files to Android build config Add paths to the remaining WebRTC .isolate files so that they can be found during test execution on Android devices. With this, they will be picked up when the test is executed using build/android/test_runner.py. BUG=webrtc:1882 TEST=Inspecting the resulting dict in a Python interpreter. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219995

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	build/android/pylib/gtest/setup.py	View		2 chunks	+23 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kjellander_chromium

Hi Craig, I picked you as reviewer since you reviewed hellner's https://codereview.chromium.org/19220004

7 years, 3 months ago (2013-08-26 12:34:07 UTC) #1

frankf

Please run android trybots. lgtm. https://codereview.chromium.org/23004021/diff/1/build/android/pylib/gtest/setup.py File build/android/pylib/gtest/setup.py (right): https://codereview.chromium.org/23004021/diff/1/build/android/pylib/gtest/setup.py#newcode63 build/android/pylib/gtest/setup.py:63: for test,isolate_path in _WEBRTC_ISOLATE_FILE_PATHS.items(): ...

7 years, 3 months ago (2013-08-27 18:34:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/23004021/1

7 years, 3 months ago (2013-08-28 06:05:09 UTC) #3

Message was sent while issue was closed.

Change committed as 219995

Expand Messages | Collapse Messages