Issue 23004008: Don't require getLength on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23004008: Don't require getLength on Mac. (Closed)

Created:
7 years, 4 months ago by scroggo

Modified:
7 years, 3 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Don't require getLength on Mac. For consistency with our other image decoders, do not depend on getLength in Mac specific decoder. BUG=skia:1570 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10990

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	gyp/images.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/ports/SkImageDecoder_CG.cpp	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

scroggo

7 years, 3 months ago (2013-08-28 19:13:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r10990 (presubmit successful).