Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2300373002: Shorten some names in ScopeInfo. (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Shorten some names in ScopeInfo. Remove the "Entry"/"Entries" suffix as it doesn't add any information and ModuleInfoEntry would clash with another name being introduced soon. R=adamk@chromium.org BUG= Committed: https://crrev.com/26a6825017a487f91f3e3eb0817ac8d1dd4a43df Cr-Commit-Position: refs/heads/master@{#39333}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -86 lines) Patch
M src/ast/scopeinfo.cc View 1 23 chunks +60 lines, -68 lines 0 comments Download
M src/objects.h View 1 2 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
neis
4 years, 3 months ago (2016-09-02 11:29:26 UTC) #1
adamk
lgtm
4 years, 3 months ago (2016-09-02 17:11:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300373002/20001
4 years, 3 months ago (2016-09-12 08:19:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 08:50:38 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 08:50:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26a6825017a487f91f3e3eb0817ac8d1dd4a43df
Cr-Commit-Position: refs/heads/master@{#39333}

Powered by Google App Engine
This is Rietveld 408576698