Chromium Code Reviews Chromium Code Reviews
Issue
2300353002:
Revert of Make TrayDetailsView a ViewClickListener and ButtonListener (Closed)
DescriptionRevert of Make TrayDetailsView a ViewClickListener and ButtonListener (patchset #5 id:80001 of https://codereview.chromium.org/2289223002/ )
Reason for revert:
This CL breaks TrayDetailsViewTest.HoverHighlightViewTouchFeedback on:
Linux ChromiumOS Tests (dbg)(1)
and
Linux Chromium OS ASan LSan Tests (1
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15828
[ RUN ] TrayDetailsViewTest.HoverHighlightViewTouchFeedback
Xlib: extension "RANDR" missing on display ":9".
=================================================================
==5332==ERROR: AddressSanitizer: heap-use-after-free on address 0x616000324580 at pc 0x0000007871d6 bp 0x7ffe4d468250 sp 0x7ffe4d468248
READ of size 1 at 0x616000324580 thread T0
#0 0x7871d5 in hover ash/common/system/tray/hover_highlight_view.h:89:31
#1 0x7871d5 in ash::test::TrayDetailsViewTest_HoverHighlightViewTouchFeedback_Test::TestBody() ash/common/system/tray/tray_details_view_unittest.cc:205
#2 0x24fe1bb in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
#3 0x24fe1bb in testing::Test::Run() testing/gtest/src/gtest.cc:2474
#4 0x250024b in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
#5 0x2501006 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
#6 0x2515006 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
#7 0x2514667 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
#8 0x2514667 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255
#9 0x1b28b8b in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
#10 0x1b28b8b in base::TestSuite::Run() base/test/test_suite.cc:246
#11 0x1b2c5b4 in Run base/callback.h:388:12
#12 0x1b2c5b4 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1> const&) base/test/launcher/unit_test_launcher.cc:206
#13 0x1b2c26e in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1> const&) base/test/launcher/unit_test_launcher.cc:445:10
#14 0xcab0de in main ash/test/ash_unittests.cc:14:10
#15 0x7fe83864e7ec in __libc_start_main /build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226
Original issue's description:
> Make TrayDetailsView a ViewClickListener and ButtonListener
>
> Some initial changes in preparation for implementing
> the material design version of the detailed views
> in the Ash system menu:
>
> * Make TrayDetailsView extend ViewClickListener
> and ButtonListener instead of having each of
> TrayDetailsView's subclasses extend these.
> The aim is to place common code in TrayDetailsView.
>
> * Rename the TrayDetailsView "footer row" to be
> the "title row"; for material design this row
> appears at the top of the detailed view, not
> the bottom.
>
> * For material design (--ash-md=experimental), show
> the title row at the top of the detailed view
> and do not instantiate or show any non-MD
> buttons in this row. Further improvements to
> the appearance and functionality of the title
> rows to be handled in subsequent CLs.
>
> BUG=642136
> TEST=ash_unittests
>
> Committed: https://crrev.com/bd26b635c2b1e5ad8287a4f87d87f5ce2c697267
> Cr-Commit-Position: refs/heads/master@{#416134}
TBR=varkha@chromium.org,oshima@chromium.org,tdanderson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642136
Committed: https://crrev.com/d2e8721e43d5b6e8fbcb5de6b6f8744e10c7e205
Cr-Commit-Position: refs/heads/master@{#416222}
Patch Set 1 #Messages
Total messages: 8 (4 generated)
|
