[gn] Add generic subcommands and provide list command

[gn] Add generic subcommands and provide list command

This prepares using mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
NOTRY=true

Committed: https://crrev.com/6c51c7d3a1fab2e918d8ead4f8b76be523bef79e
Cr-Commit-Position: refs/heads/master@{#39136}

[Michael Achenbach, 2016-09-02 09:33:44]

Description was changed from

==========
[gn] Add generic subcommands and provide list command

BUG=
==========

to

==========
[gn] Add generic subcommands and provide list command

BUG=chromium:625791
==========

[Michael Achenbach, 2016-09-02 09:37:37]

Description was changed from

==========
[gn] Add generic subcommands and provide list command

BUG=chromium:625791
==========

to

==========
[gn] Add generic subcommands and provide list command

This prepares to use mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

BUG=chromium:625791
==========

[Michael Achenbach, 2016-09-02 10:31:12]

Description was changed from

==========
[gn] Add generic subcommands and provide list command

This prepares to use mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

BUG=chromium:625791
==========

to

==========
[gn] Add generic subcommands and provide list command

This prepares to use mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
==========

[Michael Achenbach, 2016-09-02 10:31:12]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, tandrii@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-09-02 10:31:33]

PTAL. +tandrii for python readability.

https://codereview.chromium.org/2300333002/diff/40001/tools/dev/v8gen.py
File tools/dev/v8gen.py (right):

https://codereview.chromium.org/2300333002/diff/40001/tools/dev/v8gen.py#newc...
tools/dev/v8gen.py:75: def add_common_options(p):
Common options moved 1:1 from lines 71 and 78

https://codereview.chromium.org/2300333002/diff/40001/tools/dev/v8gen.py#newc...
tools/dev/v8gen.py:156: # The directories are separated with slashes in a gn
context (platform
This moved from line 202-234.

[Michael Achenbach, 2016-09-02 10:38:44]

Description was changed from

==========
[gn] Add generic subcommands and provide list command

This prepares to use mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
==========

to

==========
[gn] Add generic subcommands and provide list command

This prepares using mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
==========

[jochen (gone - plz use gerrit), 2016-09-02 12:35:49]

my question remains, however, why x86 instead of ia32?

[tandrii(chromium), 2016-09-02 12:37:23]

lgtm

[Michael Achenbach, 2016-09-02 12:38:09]

On 2016/09/02 12:35:49, jochen wrote:
> my question remains, however, why x86 instead of ia32?

Would you like to keep the toplevel configuration name ia32? We could do that,
but would need to map v8_target_cpu to x86 on the gn level.

[jochen (gone - plz use gerrit), 2016-09-02 12:40:29]

On 2016/09/02 at 12:38:09, machenbach wrote:
> On 2016/09/02 12:35:49, jochen wrote:
> > my question remains, however, why x86 instead of ia32?
> 
> Would you like to keep the toplevel configuration name ia32? We could do that,
but would need to map v8_target_cpu to x86 on the gn level.

can we make v8gen.py ia32.release just internally map to x86?

it would still create out.gn/ia32.release/args.gni but the file would contain
target_cpu = x86

[Michael Achenbach, 2016-09-02 12:48:10]

On 2016/09/02 12:40:29, jochen wrote:
> On 2016/09/02 at 12:38:09, machenbach wrote:
> > On 2016/09/02 12:35:49, jochen wrote:
> > > my question remains, however, why x86 instead of ia32?
> > 
> > Would you like to keep the toplevel configuration name ia32? We could do
that,
> but would need to map v8_target_cpu to x86 on the gn level.
> 
> can we make v8gen.py ia32.release just internally map to x86?
> 
> it would still create out.gn/ia32.release/args.gni but the file would contain
> target_cpu = x86

Done

[jochen (gone - plz use gerrit), 2016-09-02 12:52:19]

lgtm

[Michael Achenbach, 2016-09-02 13:05:11]

Description was changed from

==========
[gn] Add generic subcommands and provide list command

This prepares using mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
==========

to

==========
[gn] Add generic subcommands and provide list command

This prepares using mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
NOTRY=true
==========

[Michael Achenbach, 2016-09-02 13:05:15]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-09-02 13:05:15]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2300333002/#ps60001
(title: "s/x86/ia32")

[commit-bot: I haz the power, 2016-09-02 13:05:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 13:07:21]

Description was changed from

==========
[gn] Add generic subcommands and provide list command

This prepares using mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
NOTRY=true
==========

to

==========
[gn] Add generic subcommands and provide list command

This prepares using mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-02 13:07:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 13:07:35]

Description was changed from

==========
[gn] Add generic subcommands and provide list command

This prepares using mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
NOTRY=true
==========

to

==========
[gn] Add generic subcommands and provide list command

This prepares using mb as a library and not as a sub
process. It is used like that in the new list command that
shows available configurations.

Also added more robust checks of user inputs, better hints
and better docu.

BUG=chromium:625791
NOTRY=true

Committed: https://crrev.com/6c51c7d3a1fab2e918d8ead4f8b76be523bef79e
Cr-Commit-Position: refs/heads/master@{#39136}
==========

[commit-bot: I haz the power, 2016-09-02 13:07:36]

Patchset 4 (id:??) landed as
https://crrev.com/6c51c7d3a1fab2e918d8ead4f8b76be523bef79e
Cr-Commit-Position: refs/heads/master@{#39136}