Adding performance tests for HQP that represent importance of optimising HistoryItemsForTerms method

components/BUILD.gn

Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index 198c46060746be569e7272088c27037f72ff1847..a45e8a5ba825eeefdeb26f224eaf6f4ece2b7466 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -462,6 +462,7 @@ if (!is_ios) {
 
   test("components_perftests") {
     sources = [
+      "omnibox/browser/history_quick_provider_performance_unittest.cc",

[Peter Kasting, 2016/10/24 22:28:28]

Nit: For cleanliness, it may make sense to have this source file and its deps
defined as a separate source_set (in a BUILD.gn file in omnibox/browser/?) and
pulled in here as a dependency?  Not sure if we have a best practice here, maybe
ask brettw or dpranke.

[dyaroshev, 2016/10/25 18:11:34]

I looked at cc_perftests
(https://cs.chromium.org/chromium/src/cc/BUILD.gn?q=cc/BUILD.gn&sq=package:chr...)

[Peter Kasting, 2016/10/25 18:27:56]

Right, but cc/ is more of a true monolithic thing, while components/ is a giant
catchall for dozens of unrelated pieces.  If this gets heavily used over time,
the list could get unwieldy.

I don't know for sure that what's being done here is wrong, but I don't think
cc_perftests is necessarily the right model for this.  Hence my suggestion to
check with a gn-knowledgeable person.

[dyaroshev, 2016/10/25 23:06:46]

@brettw can you please take a look?

[dyaroshev, 2016/10/26 22:29:12]

Seems like this is the last issue if not counting attention errors.

[brettw, 2016/10/27 00:11:53]

This could go either way. If we're going to add a bunch more files to this list,
splitting it up does make more sense. If it stays just a couple of random files,
this current structure makes more sense. My impression is that these perftest
targets don't really grow that much over time, so I think it's fine to leave
as-is.

       "test/run_all_perftests.cc",
       "visitedlink/test/visitedlink_perftest.cc",
     ]
@@ -471,6 +472,9 @@ if (!is_ios) {
 
     deps = [
       "//base",
+      "//components/history/core/test",
+      "//components/omnibox/browser",
+      "//components/omnibox/browser:test_support",
       "//components/test:test_support",
       "//components/visitedlink/browser",
       "//testing/perf",