Adding performance tests for HQP that represent importance of optimising HistoryItemsForTerms method

chrome/test/base/ui_test_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/ui_test_utils.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 299 matching lines @@
 
 app_modal::AppModalDialog* WaitForAppModalDialog() {
   app_modal::AppModalDialogQueue* dialog_queue =
       app_modal::AppModalDialogQueue::GetInstance();
   if (dialog_queue->HasActiveDialog())
     return dialog_queue->active_dialog();
   AppModalDialogWaiter waiter;
   return waiter.Wait();
 }
 
+void WaitForAutocompleteController(
+    const AutocompleteController& autocomplete_controller) {
+  while (!autocomplete_controller.done()) {
+    content::WindowedNotificationObserver ready_observer(

[Paweł Hajdan Jr., 2016/09/06 14:22:10]

Shouldn't the observer be instantiated before any actions which may trigger the
notification?

+        chrome::NOTIFICATION_AUTOCOMPLETE_CONTROLLER_RESULT_READY,
+        content::Source<AutocompleteController>(&autocomplete_controller));
+    ready_observer.Wait();
+  }
+}
+
 int FindInPage(WebContents* tab,
                const base::string16& search_string,
                bool forward,
                bool match_case,
                int* ordinal,
                gfx::Rect* selection_rect) {
   FindTabHelper* find_tab_helper = FindTabHelper::FromWebContents(tab);
   find_tab_helper->StartFinding(search_string, forward, match_case);
   FindInPageNotificationObserver observer(tab);
   observer.Wait();
@@ skipping 20 matching lines @@
   ui_test_utils::NavigateToURL(browser, download_url);
   observer->WaitForFinished();
 }
 
 void SendToOmniboxAndSubmit(LocationBar* location_bar,
                             const std::string& input) {
   OmniboxView* omnibox = location_bar->GetOmniboxView();
   omnibox->model()->OnSetFocus(false);
   omnibox->SetUserText(base::ASCIIToUTF16(input));
   location_bar->AcceptInput();
-  while (!omnibox->model()->autocomplete_controller()->done()) {
-    content::WindowedNotificationObserver observer(
-        chrome::NOTIFICATION_AUTOCOMPLETE_CONTROLLER_RESULT_READY,
-        content::NotificationService::AllSources());
-    observer.Wait();
-  }
+  WaitForAutocompleteController(*omnibox->model()->autocomplete_controller());
 }
 
 Browser* GetBrowserNotInSet(const std::set<Browser*>& excluded_browsers) {
   for (auto* browser : *BrowserList::GetInstance()) {
     if (excluded_browsers.find(browser) == excluded_browsers.end())
       return browser;
   }
   return nullptr;
 }
 
@@ skipping 160 matching lines @@
         new content::MessageLoopRunner;
     WaitHistoryLoadedObserver observer(runner.get());
     ScopedObserver<history::HistoryService, history::HistoryServiceObserver>
         scoped_observer(&observer);
     scoped_observer.Add(history_service);
     runner->Run();
   }
 }
 
 }  // namespace ui_test_utils