Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 23003031: Extract interceptor calls from raw is-checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix optimization of interceptors for HIs. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of js_backend; 5 part of js_backend;
6 6
7 class JavaScriptItemCompilationContext extends ItemCompilationContext { 7 class JavaScriptItemCompilationContext extends ItemCompilationContext {
8 final Set<HInstruction> boundsChecked; 8 final Set<HInstruction> boundsChecked;
9 9
10 JavaScriptItemCompilationContext() 10 JavaScriptItemCompilationContext()
(...skipping 1266 matching lines...) Expand 10 before | Expand all | Expand 10 after
1277 ? const PropertyCheckedModeHelper( 1277 ? const PropertyCheckedModeHelper(
1278 const SourceString('propertyTypeCast')) 1278 const SourceString('propertyTypeCast'))
1279 : const PropertyCheckedModeHelper( 1279 : const PropertyCheckedModeHelper(
1280 const SourceString('propertyTypeCheck')); 1280 const SourceString('propertyTypeCheck'));
1281 } 1281 }
1282 } 1282 }
1283 } 1283 }
1284 } 1284 }
1285 } 1285 }
1286 1286
1287 /**
1288 * Returns [:true:] if the checking of [type] is performed directly on the
1289 * object and not on an interceptor.
1290 */
1291 bool hasDirectCheckFor(DartType type) {
1292 Element element = type.element;
1293 return element == compiler.stringClass ||
1294 element == compiler.boolClass ||
1295 element == compiler.numClass ||
1296 element == compiler.intClass ||
1297 element == compiler.doubleClass ||
1298 element == jsArrayClass ||
1299 element == jsMutableArrayClass ||
1300 element == jsExtendableArrayClass ||
1301 element == jsFixedArrayClass;
1302 }
1303
1287 Element getExceptionUnwrapper() { 1304 Element getExceptionUnwrapper() {
1288 return compiler.findHelper(const SourceString('unwrapException')); 1305 return compiler.findHelper(const SourceString('unwrapException'));
1289 } 1306 }
1290 1307
1291 Element getThrowRuntimeError() { 1308 Element getThrowRuntimeError() {
1292 return compiler.findHelper(const SourceString('throwRuntimeError')); 1309 return compiler.findHelper(const SourceString('throwRuntimeError'));
1293 } 1310 }
1294 1311
1295 Element getThrowAbstractClassInstantiationError() { 1312 Element getThrowAbstractClassInstantiationError() {
1296 return compiler.findHelper( 1313 return compiler.findHelper(
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
1621 copy(constant.values); 1638 copy(constant.values);
1622 copy(constant.protoValue); 1639 copy(constant.protoValue);
1623 copy(constant); 1640 copy(constant);
1624 } 1641 }
1625 1642
1626 void visitConstructed(ConstructedConstant constant) { 1643 void visitConstructed(ConstructedConstant constant) {
1627 copy(constant.fields); 1644 copy(constant.fields);
1628 copy(constant); 1645 copy(constant);
1629 } 1646 }
1630 } 1647 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698