Issue 23003028: Turn on i18n support by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23003028: Turn on i18n support by default (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 3 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
M	Makefile	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Makefile.nacl	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	build/features.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/standalone.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/samples.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/d8.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

danno

lgtm. There won't be a better time to do this. This is seems like the ...

7 years, 3 months ago (2013-09-16 12:55:45 UTC) #2

Michael Achenbach

The NaCl build is not compiling with i18n support. Please add a line to Makefile.nacl: ...

7 years, 3 months ago (2013-09-17 09:41:42 UTC) #3

Michael Achenbach

You could also merge https://codereview.chromium.org/23702044/ into this CL, inverting the condition for the test flags.

7 years, 3 months ago (2013-09-17 09:49:38 UTC) #4

jochen (gone - plz use gerrit)

7 years, 3 months ago (2013-09-18 08:11:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r16783 (presubmit successful).