Avoid array bounds check when allowed by guarded field.

runtime/vm/intermediate_language_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
@@ skipping 4307 matching lines @@
     }
     ASSERT((Smi::Cast(length_loc.constant()).Value() <=
             Smi::Cast(index_loc.constant()).Value()) ||
            (Smi::Cast(index_loc.constant()).Value() < 0));
     // Unconditionally deoptimize for constant bounds checks because they
     // only occur only when index is out-of-bounds.
     __ b(deopt);
     return;
   }
 
+  intptr_t guarded_array_length = -1;

[srdjan, 2013/08/22 22:02:43]

Instead of checking here, move the code to CheckArrayBoundInstr::Canonicalize to
eliminated redundant bounds checks.

+  if (array_ != NULL) {
+    if (array_->guarded_list_length() >= 0) {
+      guarded_array_length = array_->guarded_list_length();
+    }
+  }
+
+  if (index_loc.IsConstant() && guarded_array_length >= 0) {
+    const Object& index = Smi::Cast(index_loc.constant());
+    int32_t i = reinterpret_cast<int32_t>(index.raw());
+    if (i >= guarded_array_length) {
+      // We know this bounds check will trigger a deoptimization.
+      __ b(deopt);
+    }
+    // Nothing to emit.
+    return;
+  }
+
   if (index_loc.IsConstant()) {
     Register length = length_loc.reg();
     const Smi& index = Smi::Cast(index_loc.constant());
     __ CompareImmediate(length, reinterpret_cast<int32_t>(index.raw()));
     __ b(deopt, LS);
   } else if (length_loc.IsConstant()) {
     const Smi& length = Smi::Cast(length_loc.constant());
     Register index = index_loc.reg();
     __ CompareImmediate(index, reinterpret_cast<int32_t>(length.raw()));
     __ b(deopt, CS);
@@ skipping 305 matching lines @@
   compiler->GenerateCall(token_pos(),
                          &label,
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM