Remove usage of dart:utf from dart:io.

Remove usage of dart:utf from dart:io.

R=ajohnsen@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26586

[floitsch, 2013-08-22 16:40:12]

Special cased the decoding of UTF-8.

[Anders Johnsen, 2013-08-23 06:07:12]

LGTM.

Again, I must admit, dart:convert rocks! :)

https://codereview.chromium.org/23003023/diff/7001/sdk/lib/io/stdio.dart
File sdk/lib/io/stdio.dart (right):

https://codereview.chromium.org/23003023/diff/7001/sdk/lib/io/stdio.dart#newc...
sdk/lib/io/stdio.dart:63: const CARRIAGE_RETURN = 13;
We normally use CR and LF for these constants in IO.

https://codereview.chromium.org/23003023/diff/7001/sdk/lib/io/websocket_impl....
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/23003023/diff/7001/sdk/lib/io/websocket_impl....
sdk/lib/io/websocket_impl.dart:307: closeReason =
_decodeUtf8Strict(_controlPayload.sublist(2));
NYC, but you can remove the _decodeUtf8Strict by just replacing it here with
UTF8.decode(...).

https://codereview.chromium.org/23003023/diff/7001/tests/standalone/io/string...
File tests/standalone/io/string_decoder_test.dart (right):

https://codereview.chromium.org/23003023/diff/7001/tests/standalone/io/string...
tests/standalone/io/string_decoder_test.dart:9: const
_UNICODE_REPLACEMENT_CHARACTER_CODEPOINT = 0xFFFD;
You don't really have to make it private here.

[floitsch, 2013-08-23 08:51:58]

https://codereview.chromium.org/23003023/diff/7001/sdk/lib/io/stdio.dart
File sdk/lib/io/stdio.dart (right):

https://codereview.chromium.org/23003023/diff/7001/sdk/lib/io/stdio.dart#newc...
sdk/lib/io/stdio.dart:63: const CARRIAGE_RETURN = 13;
On 2013/08/23 06:07:12, Anders Johnsen wrote:
> We normally use CR and LF for these constants in IO.

Done.

https://codereview.chromium.org/23003023/diff/7001/sdk/lib/io/websocket_impl....
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/23003023/diff/7001/sdk/lib/io/websocket_impl....
sdk/lib/io/websocket_impl.dart:307: closeReason =
_decodeUtf8Strict(_controlPayload.sublist(2));
On 2013/08/23 06:07:12, Anders Johnsen wrote:
> NYC, but you can remove the _decodeUtf8Strict by just replacing it here with
> UTF8.decode(...).

Done.

https://codereview.chromium.org/23003023/diff/7001/tests/standalone/io/string...
File tests/standalone/io/string_decoder_test.dart (right):

https://codereview.chromium.org/23003023/diff/7001/tests/standalone/io/string...
tests/standalone/io/string_decoder_test.dart:9: const
_UNICODE_REPLACEMENT_CHARACTER_CODEPOINT = 0xFFFD;
On 2013/08/23 06:07:12, Anders Johnsen wrote:
> You don't really have to make it private here.

Done.

[Søren Gjesse, 2013-08-23 08:52:01]

lgtm

[floitsch, 2013-08-23 09:08:56]

Committed patchset #5 manually as r26586 (presubmit successful).