Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 23003015: Added documentation for Courgette internals. (Closed)

Created:
7 years, 4 months ago by paulgazz
Modified:
7 years, 3 months ago
Reviewers:
dgarrett, zeuthen, Ben Chan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added documentation for Courgette internals. It consists of a markdown file, png diagrams, and the generated html output. BUG=274829 R=benchan@chromium.org, dgarrett@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220113

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -0 lines) Patch
A courgette/application.png View Binary file 0 comments Download
A courgette/description.html View 1 chunk +147 lines, -0 lines 2 comments Download
A courgette/description.md View 1 chunk +157 lines, -0 lines 0 comments Download
A courgette/generation.png View Binary file 0 comments Download

Messages

Total messages: 9 (0 generated)
dgarrett
LGTM
7 years, 4 months ago (2013-08-20 16:19:49 UTC) #1
Ben Chan
https://codereview.chromium.org/23003015/diff/1/courgette/description.html File courgette/description.html (right): https://codereview.chromium.org/23003015/diff/1/courgette/description.html#newcode119 courgette/description.html:119: <p><strong>Adjust</strong>: Reassign address indices in the new program to ...
7 years, 4 months ago (2013-08-20 16:50:40 UTC) #2
paulgazz
On 2013/08/20 16:50:40, Ben Chan wrote: > https://codereview.chromium.org/23003015/diff/1/courgette/description.html > File courgette/description.html (right): > > https://codereview.chromium.org/23003015/diff/1/courgette/description.html#newcode119 ...
7 years, 4 months ago (2013-08-21 07:21:30 UTC) #3
Ben Chan
On 2013/08/21 07:21:30, paulgazz wrote: > On 2013/08/20 16:50:40, Ben Chan wrote: > > https://codereview.chromium.org/23003015/diff/1/courgette/description.html ...
7 years, 4 months ago (2013-08-21 15:57:53 UTC) #4
dgarrett
https://codereview.chromium.org/23003015/diff/1/courgette/description.html File courgette/description.html (right): https://codereview.chromium.org/23003015/diff/1/courgette/description.html#newcode119 courgette/description.html:119: <p><strong>Adjust</strong>: Reassign address indices in the new program to ...
7 years, 4 months ago (2013-08-21 19:03:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/paulgazz@chromium.org/23003015/1
7 years, 4 months ago (2013-08-21 19:11:51 UTC) #6
commit-bot: I haz the power
Can't process patch for file courgette/application.png. Binary file support is temporarilly disabled due to a ...
7 years, 4 months ago (2013-08-21 19:11:55 UTC) #7
dgarrett
On 2013/08/21 19:11:55, I haz the power (commit-bot) wrote: > Can't process patch for file ...
7 years, 4 months ago (2013-08-22 21:15:59 UTC) #8
dgarrett
7 years, 3 months ago (2013-08-28 23:09:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r220113.

Powered by Google App Engine
This is Rietveld 408576698