Appending working for library_list.json

pkg/docgen/lib/docgen.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * **docgen** is a tool for creating machine readable representations of Dart
  * code metadata, including: classes, members, comments and annotations.
  *
  * docgen is run on a `.dart` file or a directory containing `.dart` files.
  *
@@ skipping 226 matching lines @@
     }
   });
   // After everything is created, do a pass through all classes to make sure no
   // intermediate classes created by mixins are included.
   entityMap.values.where((e) => e is Class).forEach((c) => c.makeValid());
   // Everything is a subclass of Object, therefore empty the list to avoid a
   // giant list of subclasses to be printed out.
   if (parseSdk) entityMap['dart.core.Object'].subclasses.clear();
 
   var filteredEntities = entityMap.values.where(_isVisible);
+  
+  // Outputs a YAML or JSON file with all libraries and their preview comments 
+  // after creating all libraries. This will help the viewer know what 
+  // libraries are available to read in.
+  var libraryMap;
+  if (append) {
+    var docsDir = listDir('docs');
+    if (docsDir.contains('docs/library_list.json')){

[Bob Nystrom, 2013/08/16 20:51:10]

Nit: space before "{".

Also, I would flip the condition and do the throw first, then you don't need an
else:

if (!docsDir.contains(...) {
  throw new StateError(...);
}

libraryMap = ...

[janicejl, 2013/08/16 21:33:45]

Done.

+      libraryMap = parse(new File('docs/library_list.json').readAsStringSync());
+    } else {
+      throw new StateError('No library_list.json.');
+    }
+    libraryMap['libraries'].addAll(filteredEntities.where((e) => 
+          e is Library).map((e) => e.previewMap).toList());

[Bob Nystrom, 2013/08/16 20:51:10]

Nit, how about wrapping this on ".", like:

libraryMap['libraries'].addAll(filteredEntities
    .where((e) => e is Library)
    .map((e) => e.previewMap));

Also, you don't need the .toList().

[janicejl, 2013/08/16 21:33:45]

Done.

+    if (introduction.isNotEmpty) {
+      var intro = libraryMap['introduction'];
+      if (intro.isNotEmpty) {
+        intro = intro + '<br/><br/>' + markdown.markdownToHtml(

[Bob Nystrom, 2013/08/16 20:51:10]

intro += '<br/><br/>'...

[Bob Nystrom, 2013/08/16 20:51:10]

You can get rid of some duplicate code:

var intro = libraryMap['introduction'];
if (intro.isNotEmpty) intro += '<br/><br/>';
intro += markdown.markdownToHtml(...);
libraryMap['introduction'] = intro;

[janicejl, 2013/08/16 21:33:45]

Done.

+            new File(introduction).readAsStringSync(), 
+                linkResolver: linkResolver, inlineSyntaxes: markdownSyntaxes);
+      } else {
+        intro = markdown.markdownToHtml(new File(introduction)
+            .readAsStringSync(), linkResolver: linkResolver, 
+                inlineSyntaxes: markdownSyntaxes);
+      }
+      libraryMap['introduction'] = intro;
+    }
+    outputToYaml = libraryMap['filetype'] == 'yaml';
+  } else {
+    libraryMap = {
+      'libraries' : filteredEntities.where((e) => 
+          e is Library).map((e) => e.previewMap).toList(),
+      'introduction' : introduction == '' ? 
+          '' : markdown.markdownToHtml(new File(introduction)
+              .readAsStringSync(), linkResolver: linkResolver, 
+                  inlineSyntaxes: markdownSyntaxes), 
+      'filetype' : outputToYaml ? 'yaml' : 'json'
+    };
+  }
+  _writeToFile(stringify(libraryMap), 'library_list.json');
   // Output libraries and classes to file after all information is generated.
   filteredEntities.where((e) => e is Class || e is Library).forEach((output) {
     _writeIndexableToFile(output, outputToYaml);
   });
-  // Outputs a YAML or JSON file with all libraries and their preview comments 
-  // after creating all libraries. This will help the viewer know what 
-  // libraries are available to read in.
-  var libraryMap = {
-    'libraries' : filteredEntities.where((e) => 
-        e is Library).map((e) => e.previewMap).toList(),
-    'introduction' : introduction == '' ? 
-        '' : markdown.markdownToHtml(new File(introduction).readAsStringSync(),
-            linkResolver: linkResolver, inlineSyntaxes: markdownSyntaxes)
-  };
-  if (outputToYaml) {
-    _writeToFile(getYamlString(libraryMap), 'library_list.yaml', 
-        append: append);
-  } else {
-    _writeToFile(stringify(libraryMap), 'library_list.json', append: append);
-  }
   // Outputs all the qualified names documented with their type.
   // This will help generate search results.
   _writeToFile(filteredEntities.map((e) => 
       '${e.qualifiedName} ${e.typeName}').join('\n'),
       'index.txt', append: append);
 }
 
 Library generateLibrary(dart2js.Dart2JsLibraryMirror library) {
   _currentLibrary = library;
   var result = new Library(library.qualifiedName, _commentToHtml(library),
@@ skipping 877 matching lines @@
   String qualifiedName;
   List<String> parameters;
 
   Annotation(this.qualifiedName, this.parameters);
 
   Map toMap() => {
     'name': qualifiedName,
     'parameters': parameters
   };
 }