fix spelling of "SBClientMalware.ResourceUrlMatchedBadIp"

fix spelling of SBClientMalware.ResourceUrlMatchedBadIp UMA metric

BUG=643539
Committed: https://crrev.com/b39bd2efd5cf400842b08d3de4b9dba83dea4708
Cr-Commit-Position: refs/heads/master@{#416300}

[Jialiu Lin, 2016-09-02 17:21:05]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2016-09-02 17:21:46]

The CQ bit was unchecked by jialiul@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:21:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:21:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:21:51]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Jialiu Lin, 2016-09-02 17:22:27]

Description was changed from

==========
fix spelling of UMA metric

BUG=643539
==========

to

==========
fix spelling of SBClientMalware.ResourceUrlMatchedBadIp UMA metric

BUG=643539
==========

[Jialiu Lin, 2016-09-02 17:23:19]

jialiul@chromium.org changed reviewers:
+ vakh@chromium.org

[Jialiu Lin, 2016-09-02 17:23:20]

Hi vakh@, 
Would you mind take a look at this tiny CL?
Thanks!

[vakh (use Gerrit instead), 2016-09-02 17:24:28]

lgtm

[Jialiu Lin, 2016-09-02 17:24:46]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:25:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 18:12:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-02 18:16:07]

Description was changed from

==========
fix spelling of SBClientMalware.ResourceUrlMatchedBadIp UMA metric

BUG=643539
==========

to

==========
fix spelling of SBClientMalware.ResourceUrlMatchedBadIp UMA metric

BUG=643539

Committed: https://crrev.com/b39bd2efd5cf400842b08d3de4b9dba83dea4708
Cr-Commit-Position: refs/heads/master@{#416300}
==========

[commit-bot: I haz the power, 2016-09-02 18:16:08]

Patchset 1 (id:??) landed as
https://crrev.com/b39bd2efd5cf400842b08d3de4b9dba83dea4708
Cr-Commit-Position: refs/heads/master@{#416300}

[Mark P, 2016-09-02 18:27:56]

drive-by:

because you were emitting the previous name, it's good practice to put the old
name in histograms.xml with an obsolete tag.  Then (i) you can look at the older
data and (ii) we'll get alerted if someone else using the same (wrong) name
again or (more possibly though still very unlikely), someone else uses something
that hashes to the same name.

--mark

[Jialiu Lin, 2016-09-02 18:38:03]

On 2016/09/02 at 18:27:56, mpearson wrote:
> drive-by:
> 
> because you were emitting the previous name, it's good practice to put the old
name in histograms.xml with an obsolete tag.  Then (i) you can look at the older
data and (ii) we'll get alerted if someone else using the same (wrong) name
again or (more possibly though still very unlikely), someone else uses something
that hashes to the same name.
> 
> --mark

Thanks, Mark. There should not be any data though, since our bad IP list has
been empty. (that's also why we did not notice this mistake earlier.)  Safe
browsing team is planning to add data to this bad ip list soon, so it is an
excellent time to get this fixed.