Links in PDF should open in a new window when shift + left clicked.

chrome/browser/resources/pdf/navigator.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Creates a new Navigator for navigating to links inside or outside the PDF.
  * @param {string} originalUrl The original page URL.
  * @param {Object} viewport The viewport info of the page.
  * @param {Object} paramsParser The object for URL parsing.
- * @param {Function} navigateInCurrentTabCallback The Callback function that
- *    gets called when navigation happens in the current tab.
- * @param {Function} navigateInNewTabCallback The Callback function
- *    that gets called when navigation happens in the new tab.
+ * @param {Object} navigatorDelegate The object with callback functions that
+ *    get called when navigation happens in the current tab, a new tab,
+ *    and a new window.
  */
-function Navigator(originalUrl,
-                   viewport,
-                   paramsParser,
-                   navigateInCurrentTabCallback,
-                   navigateInNewTabCallback) {
+function Navigator(originalUrl, viewport, paramsParser, navigatorDelegate) {
   this.originalUrl_ = originalUrl;
   this.viewport_ = viewport;
   this.paramsParser_ = paramsParser;
-  this.navigateInCurrentTabCallback_ = navigateInCurrentTabCallback;
-  this.navigateInNewTabCallback_ = navigateInNewTabCallback;
+  this.navigatorDelegate_ = navigatorDelegate;
 }
 
 /**
+ * Creates a new NavigatorDelegate for calling callback funcions when

[raymes, 2016/09/07 06:41:19]

nit: Creates a new NavigatorDelegate for calling browser-specific functions to
do the actual navigating.

[jaepark, 2016/09/07 17:49:23]

Done.

+ * navigation happens.
+ * @param {boolean} isInTab Indicates if the PDF viewer is displayed in a tab.
+ * @param {boolean} isSourceFileUrl Indicates if the navigation source is a
+ *     file:// URL.
+ */
+function NavigatorDelegate(isInTab, isSourceFileUrl) {

[raymes, 2016/09/07 06:41:19]

nit: perhaps move this class above "function Navigator" above

[jaepark, 2016/09/07 17:49:23]

Done.

+  this.isInTab_ = isInTab;
+  this.isSourceFileUrl_ = isSourceFileUrl;
+}
+
+NavigatorDelegate.prototype = {
+  /**
+   * @public
+   * Called when navigation happens in the current tab.

[raymes, 2016/09/07 06:41:19]

nit: Called when navigation should happen in the current tab.

[jaepark, 2016/09/07 17:49:23]

Done.

+   * @param {string} url The url to be opened in the current tab.
+   */
+  navigateInCurrentTab: function(url) {
+    // When the PDFviewer is inside a browser tab, prefer the tabs API because
+    // it can navigate from one file:// URL to another.
+    if (chrome.tabs && this.isInTab_ && this.isSourceFileUrl_)
+      chrome.tabs.update({url: url});
+    else
+      window.location.href = url;
+  },
+
+  /**
+   * @public
+   * Called when navigation happens in the new tab.

[raymes, 2016/09/07 06:41:19]

nit: Called when navigation should happen in a new tab.

[jaepark, 2016/09/07 17:49:23]

Done.

+   * @param {string} url The url to be opened in the new tab.
+   * @param {boolean} active Indicates if the new tab should be the active tab.
+   */
+  navigateInNewTab: function(url, active) {
+    // Prefer the tabs API because it guarantees we can just open a new tab.
+    // window.open doesn't have this guarantee.
+    if (chrome.tabs)
+      chrome.tabs.create({url: url, active: active});
+    else
+      window.open(url);
+  },
+
+  /**
+   * @public
+   * Called when navigation happens in the new window.

[raymes, 2016/09/07 06:41:19]

nit: Called when navigation should happen in a new window.

[jaepark, 2016/09/07 17:49:23]

Done.

+   * @param {string} url The url to be opened in the new window.
+   */
+  navigateInNewWindow: function(url) {
+    // Prefer the windows API because it guarantees we can just open a new
+    // window. window.open with '_blank' argument doesn't have this guarantee.
+    if (chrome.windows)
+      chrome.windows.create({url: url});
+    else
+      window.open(url, '_blank');
+  }
+};
+
+/**
  * Represents options when navigating to a new url. C++ counterpart of
  * the enum is in ui/base/window_open_disposition.h. This enum represents
  * the only values that are passed from Plugin.
  * @enum {number}
  */
 Navigator.WindowOpenDisposition = {
   CURRENT_TAB: 1,
   NEW_FOREGROUND_TAB: 3,
   NEW_BACKGROUND_TAB: 4,
   NEW_WINDOW: 6,
@@ skipping 31 matching lines @@
 
     if (!this.isValidUrl_(url))
       return;
 
     switch (disposition) {
       case Navigator.WindowOpenDisposition.CURRENT_TAB:
         this.paramsParser_.getViewportFromUrlParams(
             url, this.onViewportReceived_.bind(this));
         break;
       case Navigator.WindowOpenDisposition.NEW_BACKGROUND_TAB:
-        this.navigateInNewTabCallback_(url, false);
+        this.navigatorDelegate_.navigateInNewTab(url, false);
         break;
       case Navigator.WindowOpenDisposition.NEW_FOREGROUND_TAB:
-        this.navigateInNewTabCallback_(url, true);
+        this.navigatorDelegate_.navigateInNewTab(url, true);
         break;
       case Navigator.WindowOpenDisposition.NEW_WINDOW:
-        // TODO(jaepark): Shift + left clicking a link in PDF should open the
-        // link in a new window. See http://crbug.com/628057.
-        this.paramsParser_.getViewportFromUrlParams(
-            url, this.onViewportReceived_.bind(this));
+        this.navigatorDelegate_.navigateInNewWindow(url);
         break;
       case Navigator.WindowOpenDisposition.SAVE_TO_DISK:
         // TODO(jaepark): Alt + left clicking a link in PDF should
         // download the link.
         this.paramsParser_.getViewportFromUrlParams(
             url, this.onViewportReceived_.bind(this));
         break;
       default:
         break;
     }
@@ skipping 13 matching lines @@
 
     var newUrl = viewportPosition.url;
     hashIndex = newUrl.search('#');
     if (hashIndex != -1)
       newUrl = newUrl.substring(0, hashIndex);
 
     var pageNumber = viewportPosition.page;
     if (pageNumber != undefined && originalUrl == newUrl)
       this.viewport_.goToPage(pageNumber);
     else
-      this.navigateInCurrentTabCallback_(viewportPosition.url);
+      this.navigatorDelegate_.navigateInCurrentTab(viewportPosition.url);
   },
 
   /**
    * @private
    * Checks if the URL starts with a scheme and s not just a scheme.
    * @param {string} The input URL
    * @return {boolean} Whether the url is valid.
    */
   isValidUrl_: function(url) {
     // Make sure |url| starts with a valid scheme.
@@ skipping 67 matching lines @@
     if (isRelative) {
       var slashIndex = this.originalUrl_.lastIndexOf('/');
       var path = slashIndex != -1 ?
           this.originalUrl_.substr(0, slashIndex) : this.originalUrl_;
       return path + '/' + url;
     }
 
     return 'http://' + url;
   }
 };