Links in PDF should open in a new window when shift + left clicked.

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @return {number} Width of a scrollbar in pixels
  */
 function getScrollbarWidth() {
@@ skipping 28 matching lines @@
   }
 }
 
 /**
  * Called when navigation happens in the current tab.
  * @param {boolean} isInTab Indicates if the PDF viewer is displayed in a tab.
  * @param {boolean} isSourceFileUrl Indicates if the navigation source is a
  *     file:// URL.
  * @param {string} url The url to be opened in the current tab.
  */
 function onNavigateInCurrentTab(isInTab, isSourceFileUrl, url) {

[raymes, 2016/09/06 04:36:07]

Why not define these 3 functions inside a NavigatorDelegate class?

[jaepark, 2016/09/06 20:32:47]

Done.

   // When the PDFviewer is inside a browser tab, prefer the tabs API because
   // it can navigate from one file:// URL to another.
   if (chrome.tabs && isInTab && isSourceFileUrl)
     chrome.tabs.update({url: url});
   else
     window.location.href = url;
 }
 
 /**
  * Called when navigation happens in the new tab.
  * @param {string} url The url to be opened in the new tab.
  * @param {boolean} active Indicates if the new tab should be the active tab.
  */
 function onNavigateInNewTab(url, active) {
   // Prefer the tabs API because it guarantees we can just open a new tab.
   // window.open doesn't have this guarantee.
   if (chrome.tabs)
     chrome.tabs.create({url: url, active: active});
   else
     window.open(url);
 }
 
 /**
+ * Called when navigation happens in the new window.
+ * @param {string} url The url to be opened in the new window.
+ */
+function onNavigateInNewWindow(url) {
+  // Prefer the windows API because it guarantees we can just open a new window.
+  // window.open with '_blank' argument doesn't have this guarantee.
+  if (chrome.windows)
+    chrome.windows.create({url: url});
+  else
+    window.open(url, '_blank');
+}
+
+/**
  * Whether keydown events should currently be ignored. Events are ignored when
  * an editable element has focus, to allow for proper editing controls.
  * @param {HTMLElement} activeElement The currently selected DOM node.
  * @return {boolean} True if keydown events should be ignored.
  */
 function shouldIgnoreKeyEvents(activeElement) {
   while (activeElement.shadowRoot != null &&
          activeElement.shadowRoot.activeElement != null) {
     activeElement = activeElement.shadowRoot.activeElement;
   }
@@ skipping 170 matching lines @@
   this.browserApi_.addZoomEventListener(
       this.zoomManager_.onBrowserZoomChange.bind(this.zoomManager_));
 
   // Setup the keyboard event listener.
   document.addEventListener('keydown', this.handleKeyEvent_.bind(this));
   document.addEventListener('mousemove', this.handleMouseEvent_.bind(this));
   document.addEventListener('mouseout', this.handleMouseEvent_.bind(this));
 
   var isInTab = this.browserApi_.getStreamInfo().tabId != -1;
   var isSourceFileUrl = this.originalUrl_.indexOf('file://') == 0;
-  this.navigator_ = new Navigator(this.originalUrl_,
-                                  this.viewport_, this.paramsParser_,
-                                  onNavigateInCurrentTab.bind(undefined,
-                                                              isInTab,
-                                                              isSourceFileUrl),
-                                  onNavigateInNewTab);
+  var onNavigateCallback = {
+    currentTabCallback: onNavigateInCurrentTab.bind(undefined, isInTab,
+                                                    isSourceFileUrl),
+    newTabCallback: onNavigateInNewTab,
+    newWindowCallback: onNavigateInNewWindow
+  };
+  this.navigator_ = new Navigator(this.originalUrl_, this.viewport_,
+                                  this.paramsParser_, onNavigateCallback);

[raymes, 2016/09/06 04:36:07]

Then we could just pass in a new NavigatorDelegate here

[jaepark, 2016/09/06 20:32:47]

Done.

   this.viewportScroller_ =
       new ViewportScroller(this.viewport_, this.plugin_, window);
 
   // Request translated strings.
   chrome.resourcesPrivate.getStrings('pdf', this.handleStrings_.bind(this));
 }
 
 PDFViewer.prototype = {
   /**
    * @private
@@ skipping 601 matching lines @@
    * Each bookmark is an Object containing a:
    * - title
    * - page (optional)
    * - array of children (themselves bookmarks)
    * @type {Array} the top-level bookmarks of the PDF.
    */
   get bookmarks() {
     return this.bookmarks_;
   }
 };