Links in PDF should open in a new window when shift + left clicked.

chrome/browser/resources/pdf/navigator.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Creates a new Navigator for navigating to links inside or outside the PDF.
  * @param {string} originalUrl The original page URL.
  * @param {Object} viewport The viewport info of the page.
  * @param {Object} paramsParser The object for URL parsing.
- * @param {Function} navigateInCurrentTabCallback The Callback function that
- *    gets called when navigation happens in the current tab.
- * @param {Function} navigateInNewTabCallback The Callback function
- *    that gets called when navigation happens in the new tab.
+ * @param {Object} navigateCallback The object with callback functions that
+ *    get called when navigation happens in the current tab, a new tab,
+ *    and a new window.
  */
-function Navigator(originalUrl,
-                   viewport,
-                   paramsParser,
-                   navigateInCurrentTabCallback,
-                   navigateInNewTabCallback) {
+function Navigator(originalUrl, viewport, paramsParser, navigateCallback) {

[raymes, 2016/09/06 04:36:07]

I think it would be better to call it something like navigatorDelegate.

[jaepark, 2016/09/06 20:32:46]

Done.

   this.originalUrl_ = originalUrl;
   this.viewport_ = viewport;
   this.paramsParser_ = paramsParser;
-  this.navigateInCurrentTabCallback_ = navigateInCurrentTabCallback;
-  this.navigateInNewTabCallback_ = navigateInNewTabCallback;
+  this.navigateInCurrentTabCallback_ = navigateCallback.currentTabCallback;

[raymes, 2016/09/06 04:36:07]

this.navigatorDelegate_ = navigatorDelegate;

[jaepark, 2016/09/06 20:32:47]

Done.

+  this.navigateInNewTabCallback_ = navigateCallback.newTabCallback;
+  this.navigateInNewWindowCallback_ = navigateCallback.newWindowCallback;
 }
 
 /**
  * Represents options when navigating to a new url. C++ counterpart of
  * the enum is in ui/base/window_open_disposition.h. This enum represents
  * the only values that are passed from Plugin.
  * @enum {number}
  */
 Navigator.WindowOpenDisposition = {
   CURRENT_TAB: 1,
@@ skipping 34 matching lines @@
 
     if (!this.isValidUrl_(url))
       return;
 
     switch (disposition) {
       case Navigator.WindowOpenDisposition.CURRENT_TAB:
         this.paramsParser_.getViewportFromUrlParams(
             url, this.onViewportReceived_.bind(this));
         break;
       case Navigator.WindowOpenDisposition.NEW_BACKGROUND_TAB:
         this.navigateInNewTabCallback_(url, false);

[raymes, 2016/09/06 04:36:07]

this.navigatorDelegate_.navigateInNewTab(...);

[jaepark, 2016/09/06 20:32:47]

Done.

         break;
       case Navigator.WindowOpenDisposition.NEW_FOREGROUND_TAB:
         this.navigateInNewTabCallback_(url, true);

[raymes, 2016/09/06 04:36:07]

this.navigatorDelegate_.navigateInNewTab(...);

[jaepark, 2016/09/06 20:32:47]

Done.

         break;
       case Navigator.WindowOpenDisposition.NEW_WINDOW:
-        // TODO(jaepark): Shift + left clicking a link in PDF should open the
-        // link in a new window. See http://crbug.com/628057.
-        this.paramsParser_.getViewportFromUrlParams(
-            url, this.onViewportReceived_.bind(this));
+        this.navigateInNewWindowCallback_(url);

[raymes, 2016/09/06 04:36:07]

this.navigatorDelegate_.navigateInNewWindow(...);

etc.

[jaepark, 2016/09/06 20:32:47]

Done.

         break;
       case Navigator.WindowOpenDisposition.SAVE_TO_DISK:
         // TODO(jaepark): Alt + left clicking a link in PDF should
         // download the link.
         this.paramsParser_.getViewportFromUrlParams(
             url, this.onViewportReceived_.bind(this));
         break;
       default:
         break;
     }
@@ skipping 101 matching lines @@
     if (isRelative) {
       var slashIndex = this.originalUrl_.lastIndexOf('/');
       var path = slashIndex != -1 ?
           this.originalUrl_.substr(0, slashIndex) : this.originalUrl_;
       return path + '/' + url;
     }
 
     return 'http://' + url;
   }
 };