Links in PDF should open in a new window when shift + left clicked.

chrome/test/data/pdf/navigator_test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 function NavigateInCurrentTabCallback() {
   this.navigateCalled = false;
   this.url = undefined;
   this.callback = function(url) {
     this.navigateCalled = true;
     this.url = url;
@@ skipping 10 matching lines @@
   this.callback = function(url) {
     this.navigateCalled = true;
     this.url = url;
   }.bind(this);
   this.reset = function() {
     this.navigateCalled = false;
     this.url = undefined;
   };
 }
 
+function NavigateInNewWindowCallback() {
+  this.navigateCalled = false;
+  this.url = undefined;
+  this.callback = function(url) {
+    this.navigateCalled = true;
+    this.url = url;
+  }.bind(this);
+  this.reset = function() {
+    this.navigateCalled = false;
+    this.url = undefined;
+  };
+}

[raymes, 2016/09/05 04:29:32]

I'm not sure if it's useful to define this 3 times, perhaps we can just have
one?

[jaepark, 2016/09/06 02:49:56]

Done.

+
 /**
  * Given a |navigator|, navigate to |url| in the current tab or new tab,
  * depending on the value of |openInNewTab|. Use |viewportChangedCallback|
  * and |navigateCallback| to check the callbacks, and that the navigation
  * to |expectedResultUrl| happened.
  */
 function doNavigationUrlTest(
     navigator,
     url,
     disposition,
     expectedResultUrl,
     viewportChangedCallback,
     navigateCallback) {
   viewportChangedCallback.reset();
   navigateCallback.reset();
   navigator.navigate(url, disposition);
   chrome.test.assertFalse(viewportChangedCallback.wasCalled);
   chrome.test.assertTrue(navigateCallback.navigateCalled);
   chrome.test.assertEq(expectedResultUrl, navigateCallback.url);
 }
 
 /**
  * Helper function to run doNavigationUrlTest() for the current tab and a new
  * tab.
  */
-function doNavigationUrlTestInCurrentTabAndNewTab(
+function doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(

[raymes, 2016/09/05 04:29:32]

Perhaps just change this to doNavigationUrlTest?

Also the tests that call this don't seem to use the callbacks that get passed
in, so perhaps we can just create them in here?

[jaepark, 2016/09/06 02:49:57]

Done.

     navigator,
     url,
     expectedResultUrl,
     viewportChangedCallback,
     navigateInCurrentTabCallback,
-    navigateInNewTabCallback) {
+    navigateInNewTabCallback,
+    navigateInNewWindowCallback) {
   doNavigationUrlTest(navigator, url,
       Navigator.WindowOpenDisposition.CURRENT_TAB, expectedResultUrl,
       viewportChangedCallback, navigateInCurrentTabCallback);
   doNavigationUrlTest(navigator, url,
       Navigator.WindowOpenDisposition.NEW_BACKGROUND_TAB, expectedResultUrl,
       viewportChangedCallback, navigateInNewTabCallback);
+  doNavigationUrlTest(navigator, url,
+      Navigator.WindowOpenDisposition.NEW_WINDOW, expectedResultUrl,
+      viewportChangedCallback, navigateInNewWindowCallback);
 }
 
 var tests = [
   /**
    * Test navigation within the page, opening a url in the same tab and
    * opening a url in a new tab.
    */
   function testNavigate() {
     var mockWindow = new MockWindow(100, 100);
     var mockSizer = new MockSizer();
     var mockCallback = new MockViewportChangedCallback();
     var viewport = new Viewport(mockWindow, mockSizer, mockCallback.callback,
                                 function() {}, function() {}, 0, 1, 0);
 
     var paramsParser = new OpenPDFParamsParser(function(name) {
       if (name == 'US')
         paramsParser.onNamedDestinationReceived(0);
       else if (name == 'UY')
         paramsParser.onNamedDestinationReceived(2);
       else
         paramsParser.onNamedDestinationReceived(-1);
     });
     var url = "http://xyz.pdf";
 
     var navigateInCurrentTabCallback = new NavigateInCurrentTabCallback();
     var navigateInNewTabCallback = new NavigateInNewTabCallback();
+    var navigateInNewWindowCallback = new NavigateInNewWindowCallback();
     var navigator = new Navigator(url, viewport, paramsParser,
         navigateInCurrentTabCallback.callback,
-        navigateInNewTabCallback.callback);
+        navigateInNewTabCallback.callback,
+        navigateInNewWindowCallback.callback);
 
     var documentDimensions = new MockDocumentDimensions();
     documentDimensions.addPage(100, 100);
     documentDimensions.addPage(200, 200);
     documentDimensions.addPage(100, 400);
     viewport.setDocumentDimensions(documentDimensions);
     viewport.setZoom(1);
 
     mockCallback.reset();
     // This should move viewport to page 0.
@@ skipping 49 matching lines @@
     var viewport = new Viewport(mockWindow, mockSizer, mockCallback.callback,
                                 function() {}, function() {}, 0, 1, 0);
 
     var paramsParser = new OpenPDFParamsParser(function(name) {
       paramsParser.onNamedDestinationReceived(-1);
     });
     var url = "http://www.example.com/subdir/xyz.pdf";
 
     var navigateInCurrentTabCallback = new NavigateInCurrentTabCallback();
     var navigateInNewTabCallback = new NavigateInNewTabCallback();
+    var navigateInNewWindowCallback = new NavigateInNewWindowCallback();
     var navigator = new Navigator(url, viewport, paramsParser,
         navigateInCurrentTabCallback.callback,
-        navigateInNewTabCallback.callback);
+        navigateInNewTabCallback.callback,
+        navigateInNewWindowCallback.callback);
 
     // Sanity check.
-    doNavigationUrlTestInCurrentTabAndNewTab(
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         'https://www.foo.com/bar.pdf',
         'https://www.foo.com/bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
 
     // Open relative links.
-    doNavigationUrlTestInCurrentTabAndNewTab(
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         'foo/bar.pdf',
         'http://www.example.com/subdir/foo/bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
-    doNavigationUrlTestInCurrentTabAndNewTab(
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         'foo.com/bar.pdf',
         'http://www.example.com/subdir/foo.com/bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
     // The expected result is not normalized here.
-    doNavigationUrlTestInCurrentTabAndNewTab(
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         '../www.foo.com/bar.pdf',
         'http://www.example.com/subdir/../www.foo.com/bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
 
     // Open an absolute link.
-    doNavigationUrlTestInCurrentTabAndNewTab(
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         '/foodotcom/bar.pdf',
         'http://www.example.com/foodotcom/bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
 
     // Open a http url without a scheme.
-    doNavigationUrlTestInCurrentTabAndNewTab(
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         'www.foo.com/bar.pdf',
         'http://www.foo.com/bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
 
     // Test three dots.
-    doNavigationUrlTestInCurrentTabAndNewTab(
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         '.../bar.pdf',
         'http://www.example.com/subdir/.../bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
 
     // Test forward slashes.
-    doNavigationUrlTestInCurrentTabAndNewTab(
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         '..\\bar.pdf',
         'http://www.example.com/subdir/..\\bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
-    doNavigationUrlTestInCurrentTabAndNewTab(
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         '.\\bar.pdf',
         'http://www.example.com/subdir/.\\bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
-    doNavigationUrlTestInCurrentTabAndNewTab(
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         '\\bar.pdf',
         'http://www.example.com/subdir/\\bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
 
     // Regression test for https://crbug.com/569040
-    doNavigationUrlTestInCurrentTabAndNewTab(
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         'http://something.else/foo#page=5',
         'http://something.else/foo#page=5',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
 
     chrome.test.succeed();
   },
   /**
    * Test opening a url in the same tab and opening a url in a new tab with a
    * file:/// url as the current location.
    */
   function testNavigateFromLocalFile() {
     var mockWindow = new MockWindow(100, 100);
     var mockSizer = new MockSizer();
     var mockCallback = new MockViewportChangedCallback();
     var viewport = new Viewport(mockWindow, mockSizer, mockCallback.callback,
                                 function() {}, function() {}, 0, 1, 0);
 
     var paramsParser = new OpenPDFParamsParser(function(name) {
       paramsParser.onNamedDestinationReceived(-1);
     });
     var url = "file:///some/path/to/myfile.pdf";
 
     var navigateInCurrentTabCallback = new NavigateInCurrentTabCallback();
     var navigateInNewTabCallback = new NavigateInNewTabCallback();
+    var navigateInNewWindowCallback = new NavigateInNewWindowCallback();
     var navigator = new Navigator(url, viewport, paramsParser,
         navigateInCurrentTabCallback.callback,
-        navigateInNewTabCallback.callback);
+        navigateInNewTabCallback.callback,
+        navigateInNewWindowCallback.callback);
 
     // Open an absolute link.
-    doNavigationUrlTestInCurrentTabAndNewTab(
+    doNavigationUrlTestInCurrentTabAndNewTabAndNewWindow(
         navigator,
         '/foodotcom/bar.pdf',
         'file:///foodotcom/bar.pdf',
         mockCallback,
         navigateInCurrentTabCallback,
-        navigateInNewTabCallback);
+        navigateInNewTabCallback,
+        navigateInNewWindowCallback);
 
     chrome.test.succeed();
   }
 ];
 
 var scriptingAPI = new PDFScriptingAPI(window, window);
 scriptingAPI.setLoadCallback(function() {
   chrome.test.runTests(tests);
 });