Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2300203002: interpolation of coincidence must be local to a single span (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

interpolation of coincidence must be local to a single span Pathops makes up intersections that it doesn't detect directly, but do exist. For instance, if a is coincident with b, and b is coincident with c, then for where they overlap a is coincident with c. The intersections are made up in different ways. In a few places, the t values that are detected are interpolated to guess the t values that represent invented intersections. The interpolated t is not necessarily linear, but a linear guess is good enough if the invented t lies between known t values. Additionally, improve debugging. This passes the extended release test suite and additionally passes the first 17 levels in the tiger test suite; previously, path ops passed 7 levels. The tiger suite is composed of 37 levels in increasing complexity, described by about 300K tests. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300203002 Committed: https://skia.googlesource.com/skia/+/8016b264ceec2b11d2acbeb77a9fbe66e48368b9

Patch Set 1 #

Patch Set 2 : all test pass; tiger up to level 17 #

Patch Set 3 : fix warnings #

Patch Set 4 : fix another warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -179 lines) Patch
M src/pathops/SkOpCoincidence.h View 1 3 chunks +13 lines, -26 lines 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 2 3 7 chunks +154 lines, -77 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpSpan.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 10 chunks +111 lines, -70 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/pathops_sorter.htm View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300203002/20001
4 years, 3 months ago (2016-09-02 18:42:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot/builds/930)
4 years, 3 months ago (2016-09-02 18:45:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300203002/40001
4 years, 3 months ago (2016-09-02 18:52:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/11259)
4 years, 3 months ago (2016-09-02 18:55:27 UTC) #11
reed1
I don't understand enough of the context to actually understand the CL, but it is ...
4 years, 3 months ago (2016-09-04 17:18:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300203002/60001
4 years, 3 months ago (2016-09-06 12:24:44 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 12:59:50 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8016b264ceec2b11d2acbeb77a9fbe66e48368b9

Powered by Google App Engine
This is Rietveld 408576698