Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2300193002: Remove tsan.supp. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove tsan.supp. The remaining suppression (libwebp) is already covered by the compile-time blacklist, tools/xsan.blacklist. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300193002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,Test-Ubuntu-Clang-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot Committed: https://skia.googlesource.com/skia/+/67f6636b203acd7664db073b685609b2a960f030

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M infra/bots/infrabots.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipe_modules/flavor/xsan_flavor.py View 1 chunk +0 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 chunk +1 line, -2 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 chunk +1 line, -2 lines 0 comments Download
D tools/tsan.supp View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mtklein_C
4 years, 3 months ago (2016-09-01 20:35:15 UTC) #3
borenet
LGTM
4 years, 3 months ago (2016-09-01 20:37:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300193002/20001
4 years, 3 months ago (2016-09-01 20:55:12 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 21:57:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/67f6636b203acd7664db073b685609b2a960f030

Powered by Google App Engine
This is Rietveld 408576698