Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2300173002: GN: expunge all environment variables that have no effect on GN (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: expunge all environment variables that have no effect on GN This should have no practical effect. I just want to make sure no environment variables beyond $PATH have any effect on GN builds. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300173002 Committed: https://skia.googlesource.com/skia/+/ae509db48198840a607f943cf29b48765fb339da

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
mtklein_C
4 years, 3 months ago (2016-09-01 19:59:53 UTC) #5
borenet
LGTM
4 years, 3 months ago (2016-09-01 20:10:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300173002/1
4 years, 3 months ago (2016-09-01 20:18:05 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:19:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ae509db48198840a607f943cf29b48765fb339da

Powered by Google App Engine
This is Rietveld 408576698