Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2300163002: DevTools: Make Tracing domain experimental. (Closed)

Created:
4 years, 3 months ago by alph
Modified:
4 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make Tracing domain experimental. Committed: https://crrev.com/43caef2fe03d7bed56bb36316e053b3c7162c179 Cr-Commit-Position: refs/heads/master@{#416377}

Patch Set 1 #

Patch Set 2 : Addressing comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol-1.2.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
alph
4 years, 3 months ago (2016-09-01 19:30:57 UTC) #2
dgozman
Doesn't compat script yell at you? lgtm
4 years, 3 months ago (2016-09-02 18:14:10 UTC) #3
dgozman
Actually, please change both -1.2 and tot versions.
4 years, 3 months ago (2016-09-02 18:14:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300163002/20001
4 years, 3 months ago (2016-09-02 21:25:43 UTC) #7
alph
On 2016/09/02 18:14:10, dgozman wrote: > Doesn't compat script yell at you? Nope.
4 years, 3 months ago (2016-09-02 21:36:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 23:00:21 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 23:03:46 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/43caef2fe03d7bed56bb36316e053b3c7162c179
Cr-Commit-Position: refs/heads/master@{#416377}

Powered by Google App Engine
This is Rietveld 408576698