Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1846)

Unified Diff: chrome/browser/metrics/thread_watcher_unittest.cc

Issue 2300133002: Fix memory leak in ThreadWatcher. (Closed)
Patch Set: Implement isherman's feedback (from comment #6) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/thread_watcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/thread_watcher_unittest.cc
diff --git a/chrome/browser/metrics/thread_watcher_unittest.cc b/chrome/browser/metrics/thread_watcher_unittest.cc
index 4aca262b664fda495d657724d99aeec98ba7856d..e2489eb490a22d8725f267c942e79b199d2ee6c7 100644
--- a/chrome/browser/metrics/thread_watcher_unittest.cc
+++ b/chrome/browser/metrics/thread_watcher_unittest.cc
@@ -279,13 +279,23 @@ class ThreadWatcherTest : public ::testing::Test {
thread_watcher_list_ = new ThreadWatcherList();
// Create thread watcher object for the IO thread.
- io_watcher_ = new CustomThreadWatcher(BrowserThread::IO, kIOThreadName,
- kSleepTime, kUnresponsiveTime);
+ std::unique_ptr<CustomThreadWatcher> io_watcher(
+ new CustomThreadWatcher(BrowserThread::IO, kIOThreadName,
+ kSleepTime, kUnresponsiveTime));
+ io_watcher_ = io_watcher.get();
+ ThreadWatcher* registered_io_watcher =
+ ThreadWatcherList::Register(std::move(io_watcher));
+ EXPECT_EQ(io_watcher_, registered_io_watcher);
EXPECT_EQ(io_watcher_, thread_watcher_list_->Find(BrowserThread::IO));
// Create thread watcher object for the DB thread.
- db_watcher_ = new CustomThreadWatcher(BrowserThread::DB, kDBThreadName,
- kSleepTime, kUnresponsiveTime);
+ std::unique_ptr<CustomThreadWatcher> db_watcher(
+ new CustomThreadWatcher(BrowserThread::DB, kDBThreadName,
+ kSleepTime, kUnresponsiveTime));
+ db_watcher_ = db_watcher.get();
+ ThreadWatcher* registered_db_watcher =
+ ThreadWatcherList::Register(std::move(db_watcher));
+ EXPECT_EQ(db_watcher_, registered_db_watcher);
EXPECT_EQ(db_watcher_, thread_watcher_list_->Find(BrowserThread::DB));
{
« no previous file with comments | « chrome/browser/metrics/thread_watcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698