Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2300113002: Ensure that constant field initializers are canonicalized (Closed)

Created:
4 years, 3 months ago by hausner
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Lasse Reichstein Nielsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure that constant field initializers are canonicalized In const constructors, field initializer values that are known to be compile-time constants should be evaluated and canonicalized at compile time. BUG=#27164 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c15bac4812532215d0e286ce128493121e003fde

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M runtime/vm/parser.cc View 1 2 chunks +16 lines, -3 lines 0 comments Download
A + tests/language/regress_27164_test.dart View 1 2 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
hausner
4 years, 3 months ago (2016-09-01 17:20:38 UTC) #3
Florian Schneider
dbc: #issue number will make github automatically reference this commit in the issue. without # ...
4 years, 3 months ago (2016-09-01 19:15:09 UTC) #5
rmacnak
lgtm
4 years, 3 months ago (2016-09-01 19:59:40 UTC) #6
hausner
Thank you for the tip and the review.
4 years, 3 months ago (2016-09-01 20:18:21 UTC) #8
hausner
4 years, 3 months ago (2016-09-01 20:18:28 UTC) #9
hausner
4 years, 3 months ago (2016-09-01 20:23:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c15bac4812532215d0e286ce128493121e003fde (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698