Remove the call to getFontMetrics from SkBBoxRecord

src/core/SkBBoxRecord.cpp

 
 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkBBoxRecord.h"
 
@@ skipping 161 matching lines @@
     bbox.fLeft += pad;
     bbox.fRight -= pad;
 
     if (this->transformBounds(bbox, &paint)) {
         INHERITED::drawPosText(text, byteLength, pos, paint);
     }
 }
 
 void SkBBoxRecord::drawPosTextH(const void* text, size_t byteLength, const SkScalar xpos[],
                                 SkScalar constY, const SkPaint& paint) {
+    size_t numChars = paint.countText(text, byteLength);
+    if (numChars == 0) {
+        return;
+    }
+
+    const SkFlatData* flatPaintData = this->getFlatPaintData(paint);
+    WriteTopBot(paint, *flatPaintData);
+
+    SkScalar top = flatPaintData->topBot()[0];
+    SkScalar bottom = flatPaintData->topBot()[1];
+    SkScalar pad = top - bottom;
+
     SkRect bbox;
-    size_t numChars = paint.countText(text, byteLength);
-    if (numChars > 0) {
-        bbox.fLeft  = xpos[0];
-        bbox.fRight = xpos[numChars - 1];
-        // if we had a guarantee that these will be monotonically increasing, this could be sped up
-        for (size_t i = 1; i < numChars; ++i) {
-            if (xpos[i] < bbox.fLeft) {
-                bbox.fLeft = xpos[i];
-            }
-            if (xpos[i] > bbox.fRight) {
-                bbox.fRight = xpos[i];
-            }
+    bbox.fLeft  = xpos[0];
+    bbox.fRight = xpos[numChars - 1];
+    for (size_t i = 1; i < numChars; ++i) {

[caryclark, 2013/08/21 17:54:09]

what if xpos[0] > bbox.fRight ?

[sglez, 2013/08/21 18:11:56]

i starts at 1.

If numChars == 1, then fLeft == fRight, but that will change below when we add
the padding.

[caryclark, 2013/08/21 18:27:55]

suppose numChars == 2, xpos[0] = 3, xpos[1] = 2:

bbox.fLeft = xpos[0] = 3;
bbox.fRight = xpos[1] = 2;
for (size_t i = 1; i < 2; ++i) {
  if (xpos[1] (==2) < bbox.fLeft (==3)) {
    bboxfLeft = xpos[1] = 2;
  if (xpos[1] (==2) > bbox.fRight (==2)) {
    ... nothing happens
}

bbox.fLeft == bbox.fRight == 2

[sglez, 2013/08/21 18:43:17]

Assuming bbox.fLeft == bbox.fRight,
And assuming pad != 0;

Below, we have:

bbox.fLeft += pad;
bbox.fRight -= pad;

This will leave bbox.fLeft != bbox.fRight, which is fine, because the call to
transformBounds(..) will call bbox.sort(), leaving bbox.fLeft < bbox.fRight

If pad == 0, then top == bottom and there's something seriously wrong with the
paint. 

+        if (xpos[i] < bbox.fLeft) {
+            bbox.fLeft = xpos[i];
         }
-        SkPaint::FontMetrics metrics;
-        paint.getFontMetrics(&metrics);
-
-        // pad horizontally by max glyph height
-        SkScalar pad = (metrics.fTop - metrics.fBottom);
-        bbox.fLeft  += pad;
-        bbox.fRight -= pad;
-
-        bbox.fTop    = metrics.fTop + constY;
-        bbox.fBottom = metrics.fBottom + constY;
-        if (!this->transformBounds(bbox, &paint)) {
-            return;
+        if (xpos[i] > bbox.fRight) {
+            bbox.fRight = xpos[i];
         }
     }
-    INHERITED::drawPosTextH(text, byteLength, xpos, constY, paint);
+
+    // pad horizontally by max glyph height
+    bbox.fLeft  += pad;
+    bbox.fRight -= pad;
+
+    bbox.fTop    = top + constY;
+    bbox.fBottom = bottom + constY;
+
+    if (!this->transformBounds(bbox, &paint)) {
+        return;
+    }
+    // This is the equivalent of calling:
+    //  INHERITED::drawPosTextH(text, byteLength, xpos, constY, paint);
+    // but we filled our flat paint beforehand so that we could get font metrics.
+    drawPosTextHImpl(text, byteLength, xpos, constY, paint, flatPaintData);
 }
 
 void SkBBoxRecord::drawSprite(const SkBitmap& bitmap, int left, int top,
                               const SkPaint* paint) {
     SkRect bbox;
     bbox.set(SkIRect::MakeXYWH(left, top, bitmap.width(), bitmap.height()));
     this->handleBBox(bbox); // directly call handleBBox, matrix is ignored
     INHERITED::drawSprite(bitmap, left, top, paint);
 }
 
@@ skipping 55 matching lines @@
     }
 
     if (!outBounds.isEmpty() && !this->quickReject(outBounds)) {
         this->getTotalMatrix().mapRect(&outBounds);
         this->handleBBox(outBounds);
         return true;
     }
 
     return false;
 }