Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: buildbot/slave/skia_slave_scripts/compare_and_upload_webpage_gms.py

Issue 23001003: Remove base-* directories from gm expected/actual paths; just use platform names (Closed) Base URL: http://skia.googlecode.com/svn/
Patch Set: buildbot_slave Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: buildbot/slave/skia_slave_scripts/compare_and_upload_webpage_gms.py
===================================================================
--- buildbot/slave/skia_slave_scripts/compare_and_upload_webpage_gms.py (revision 10693)
+++ buildbot/slave/skia_slave_scripts/compare_and_upload_webpage_gms.py (working copy)
@@ -18,7 +18,7 @@
--autogen_svn_baseurl "" --make_flags "" --test_args "" --gm_args "" \
--bench_args "" --num_cores 8 --perf_output_basedir "" \
--builder_name Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release \
---got_revision 0 --gm_image_subdir base-shuttle_ubuntu12_ati5770 \
+--got_revision 0 \
--is_try False --do_upload_results True --dest_gsbase gs://rmistry
"""
@@ -51,14 +51,7 @@
'found in baseDir and not found in comparisonDir',
]
-IMAGES_FOR_UPLOAD_CHUNKS = [
- 'base-macmini',
- 'base-macmini-lion-float',
- 'base-macmini-10_8',
- 'base-shuttle_ubuntu12_ati5770',
-]
-
class CompareAndUploadWebpageGMs(BuildStep):
def __init__(
@@ -82,9 +75,7 @@
self._dest_gsbase = (self._args.get('dest_gsbase') or
sync_bucket_subdir.DEFAULT_PERFDATA_GS_BASE)
- self._upload_chunks = (
- True if self._gm_image_subdir in IMAGES_FOR_UPLOAD_CHUNKS
- else False)
+ self._upload_chunks = True
# Check if gm-expected exists on Google Storage.
self._gm_expected_exists_on_storage = gs_utils.DoesStorageObjectExist(
« no previous file with comments | « buildbot/slave/skia_slave_scripts/check_gs_timestamps.py ('k') | buildbot/slave/skia_slave_scripts/playback_dirs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698