Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2396)

Unified Diff: buildbot/master/skia_master_scripts/skia_build_step.py

Issue 23001003: Remove base-* directories from gm expected/actual paths; just use platform names (Closed) Base URL: http://skia.googlecode.com/svn/
Patch Set: buildbot_slave Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « buildbot/master/skia_master_scripts/factory.py ('k') | buildbot/master/skia_master_scripts/utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/master/skia_master_scripts/skia_build_step.py
===================================================================
--- buildbot/master/skia_master_scripts/skia_build_step.py (revision 10693)
+++ buildbot/master/skia_master_scripts/skia_build_step.py (working copy)
@@ -91,29 +91,6 @@
return False
-def _CheckRebaselineChanges(changes, gm_image_subdir):
- """ Determine whether a set of changes consists of only files in 'gm-expected'
- and whether any of those files are in the given gm_image_subdir. Returns a
- tuple consisting of two booleans: whether or not the commit consists of only
- new baseline images, and whether or not baselines changed for the given
- platform.
-
- changes: a list of the changelists which are part of this build.
- gm_image_subdir: the subdirectory inside gm-expected which corresponds to this
- build slave's platform.
- """
- commit_is_only_baselines = True
- platform_changed = False
- for change in changes:
- for changed_file in change.asDict()['files']:
- for subdir in utils.SKIA_PRIMARY_SUBDIRS:
- if subdir != 'gm-expected' and subdir in changed_file['name']:
- commit_is_only_baselines = False
- if gm_image_subdir in changed_file:
- platform_changed = True
- return commit_is_only_baselines, platform_changed
-
-
def ShouldDoStep(step):
""" At build time, use build properties to determine whether or not a step
should be run or skipped.
« no previous file with comments | « buildbot/master/skia_master_scripts/factory.py ('k') | buildbot/master/skia_master_scripts/utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698