Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: buildbot/slave/skia_slave_scripts/run_decoding_tests.py

Issue 23001003: Remove base-* directories from gm expected/actual paths; just use platform names (Closed) Base URL: http://skia.googlecode.com/svn/
Patch Set: buildbot_slave Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ Run the Skia skimage executable. """ 6 """ Run the Skia skimage executable. """
7 7
8 from build_step import BuildStep 8 from build_step import BuildStep
9 import sys 9 import sys
10 10
11 class RunDecodingTests(BuildStep): 11 class RunDecodingTests(BuildStep):
12 def _Run(self): 12 def _Run(self):
13 cmd = ['-r', self._device_dirs.SKImageInDir(), '--noreencode'] 13 cmd = ['-r', self._device_dirs.SKImageInDir(), '--noreencode']
14 14
15 # TODO(scroggo): Once we have expectations files with the new name, 15 if self._builder_name is not None:
16 # the expectations_name will use self._builder_name 16 expectations_name = self._builder_name + '.json'
17 if self._gm_image_subdir is not None:
18 expectations_name = self._gm_image_subdir + '.json'
19 17
20 # Read expectations, which were downloaded/copied to the device. 18 # Read expectations, which were downloaded/copied to the device.
21 expectations_file = self._flavor_utils.DevicePathJoin( 19 expectations_file = self._flavor_utils.DevicePathJoin(
22 self._device_dirs.SKImageExpectedDir(), 20 self._device_dirs.SKImageExpectedDir(),
23 expectations_name) 21 expectations_name)
24 22
25 if self._flavor_utils.DevicePathExists(expectations_file): 23 if self._flavor_utils.DevicePathExists(expectations_file):
26 cmd.extend(['--readExpectationsPath', expectations_file]) 24 cmd.extend(['--readExpectationsPath', expectations_file])
27 25
28 # Write the expectations file, in case any did not match. 26 # Write the expectations file, in case any did not match.
29 output_expectations_file = self._flavor_utils.DevicePathJoin( 27 output_expectations_file = self._flavor_utils.DevicePathJoin(
30 self._device_dirs.SKImageOutDir(), 28 self._device_dirs.SKImageOutDir(),
31 expectations_name) 29 expectations_name)
32 30
33 cmd.extend(['--createExpectationsPath', output_expectations_file]) 31 cmd.extend(['--createExpectationsPath', output_expectations_file])
34 32
35 # Draw any mismatches to the same folder as the output json. 33 # Draw any mismatches to the same folder as the output json.
36 cmd.extend(['--mismatchPath', self._device_dirs.SKImageOutDir()]) 34 cmd.extend(['--mismatchPath', self._device_dirs.SKImageOutDir()])
37 35
38 self._flavor_utils.RunFlavoredCmd('skimage', cmd) 36 self._flavor_utils.RunFlavoredCmd('skimage', cmd)
39 37
40 38
41 if '__main__' == __name__: 39 if '__main__' == __name__:
42 sys.exit(BuildStep.RunBuildStep(RunDecodingTests)) 40 sys.exit(BuildStep.RunBuildStep(RunDecodingTests))
OLDNEW
« no previous file with comments | « buildbot/slave/skia_slave_scripts/prerender.py ('k') | buildbot/slave/skia_slave_scripts/run_gm.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698