chrome/browser/push_messaging/push_messaging_notification_manager.h - Issue 2300093002: Make //content responsible for generating notification Ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_notification_manager.h

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)

Patch Set: Make //content responsible for generating notification Ids Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/platform_notification_service_unittest.cc ('K') | « chrome/browser/notifications/stub_notification_platform_bridge.cc ('k') | chrome/browser/push_messaging/push_messaging_notification_manager.cc » ('j') | content/browser/notifications/notification_database.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_notification_manager.h

diff --git a/chrome/browser/push_messaging/push_messaging_notification_manager.h b/chrome/browser/push_messaging/push_messaging_notification_manager.h

index 6a5256b0c3a9e45dfbbae1abdc8428dc5a2cd9df..71a8f35c1b20cac158842ca779a3d6c23bd5f9b9 100644

--- a/chrome/browser/push_messaging/push_messaging_notification_manager.h

+++ b/chrome/browser/push_messaging/push_messaging_notification_manager.h

@@ -84,14 +84,14 @@ class PushMessagingNotificationManager {

const content::PlatformNotificationData& notification_data,

const base::Closure& message_handled_closure,

bool success,

- int64_t persistent_notification_id);

+ const std::string& notification_id);

void DidWriteNotificationData(

const GURL& origin,

const content::PlatformNotificationData& notification_data,

const base::Closure& message_handled_closure,

bool success,

- int64_t persistent_notification_id);

+ const std::string& notification_id);

void DidGetBudget(const GURL& origin,

int64_t service_worker_registration_id,