Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)
Patch Set: comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
index f6e79f8fe7714f8b9488ed6525b13b5191c3b308..ecf192c361118f0ffeafdb1055bef3022cdf0759 100644
--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
@@ -58,8 +58,8 @@ public:
virtual void dispatchInstallEvent(int eventID) = 0;
virtual void dispatchFetchEvent(int responseID, int eventFinishID, const WebServiceWorkerRequest& webRequest) = 0;
virtual void dispatchForeignFetchEvent(int responseID, int eventFinishID, const WebServiceWorkerRequest& webRequest) = 0;
- virtual void dispatchNotificationClickEvent(int eventID, int64_t notificationID, const WebNotificationData&, int actionIndex) = 0;
- virtual void dispatchNotificationCloseEvent(int eventID, int64_t notificationID, const WebNotificationData&) = 0;
+ virtual void dispatchNotificationClickEvent(int eventID, const WebString& notificationID, const WebNotificationData&, int actionIndex) = 0;
+ virtual void dispatchNotificationCloseEvent(int eventID, const WebString& notificationID, const WebNotificationData&) = 0;
virtual void dispatchPushEvent(int eventID, const WebString& data) = 0;
virtual bool hasFetchEventHandler() = 0;
« no previous file with comments | « third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698