Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)
Patch Set: comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/Notification.h
diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h
index 9f10b0cca833619886fcdc6a75496adc894fd66b..bff947dbf62cbb5b3136c7f4ca04d78cd59f3d30 100644
--- a/third_party/WebKit/Source/modules/notifications/Notification.h
+++ b/third_party/WebKit/Source/modules/notifications/Notification.h
@@ -69,7 +69,7 @@ public:
// Used for embedder-created Notification objects. If |showing| is true, will initialize the
// Notification's state as showing, or as closed otherwise.
- static Notification* create(ExecutionContext*, int64_t persistentId, const WebNotificationData&, bool showing);
+ static Notification* create(ExecutionContext*, const String& notificationId, const WebNotificationData&, bool showing);
~Notification() override;
@@ -139,14 +139,14 @@ private:
// NotificationResourcesLoader.
void didLoadResources(NotificationResourcesLoader*);
- void setPersistentId(int64_t persistentId) { m_persistentId = persistentId; }
+ void setNotificationId(const String& notificationId) { m_notificationId = notificationId; }
WebNotificationData m_data;
// Notifications can either be bound to the page, which means they're identified by
// their delegate, or persistent, which means they're identified by a persistent Id
// given to us by the embedder. This influences how we close the notification.
- int64_t m_persistentId;
+ String m_notificationId;
enum NotificationState {
NotificationStateIdle,

Powered by Google App Engine
This is Rietveld 408576698