content/common/service_worker/service_worker_messages.h - Issue 2300093002: Make //content responsible for generating notification Ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)

Patch Set: comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index d41d517236e961f981ef51ef7bbdd583c7dc0e79..59af129dd12f5df863d18ace425eed15484abba0 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -497,12 +497,12 @@ IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_FetchEvent,

content::ServiceWorkerFetchRequest)

IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_NotificationClickEvent,

int /* request_id */,

- int64_t /* persistent_notification_id */,

+ std::string /* notification_id */,

content::PlatformNotificationData /* notification_data */,

int /* action_index */)

IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_NotificationCloseEvent,

int /* request_id */,

- int64_t /* persistent_notification_id */,

+ std::string /* notification_id */,

content::PlatformNotificationData /* notification_data */)

IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_PushEvent,

int /* request_id */,

« no previous file with comments | « content/common/platform_notification_messages.h ('k') | content/public/browser/BUILD.gn » ('j') | no next file with comments »