Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2004)

Unified Diff: chrome/browser/notifications/notification_object_proxy.h

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)
Patch Set: comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_object_proxy.h
diff --git a/chrome/browser/notifications/notification_object_proxy.h b/chrome/browser/notifications/notification_object_proxy.h
index e09bfff868f8590770ae578f0f2eb8d677e89d37..a49de01dd64982f3f28334e19561a8c3b4877fd5 100644
--- a/chrome/browser/notifications/notification_object_proxy.h
+++ b/chrome/browser/notifications/notification_object_proxy.h
@@ -26,6 +26,7 @@ class NotificationObjectProxy : public NotificationDelegate {
// will take ownership of |delegate|.
NotificationObjectProxy(
content::BrowserContext* browser_context,
+ const std::string& notification_id,
std::unique_ptr<content::DesktopNotificationDelegate> delegate);
// NotificationDelegate implementation.
@@ -44,7 +45,7 @@ class NotificationObjectProxy : public NotificationDelegate {
content::BrowserContext* browser_context_;
std::unique_ptr<content::DesktopNotificationDelegate> delegate_;
bool displayed_;
- std::string id_;
+ std::string notification_id_;
DISALLOW_COPY_AND_ASSIGN(NotificationObjectProxy);
};
« no previous file with comments | « chrome/browser/notifications/notification_display_service.h ('k') | chrome/browser/notifications/notification_object_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698