third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp - Issue 2300093002: Make //content responsible for generating notification Ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)

Patch Set: rebase + comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/notification_database_data.h ('K') | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h ('k') | third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

index 09a8123a7dd7d3d786ef67c0f528a115ad98c98c..4a2b2feb9e01639a4850cd0833f095e41f679516 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

@@ -197,7 +197,7 @@ void ServiceWorkerGlobalScopeProxy::dispatchInstallEvent(int eventID)

workerGlobalScope()->dispatchExtendableEvent(event, observer);

}

-void ServiceWorkerGlobalScopeProxy::dispatchNotificationClickEvent(int eventID, int64_t notificationID, const WebNotificationData& data, int actionIndex)

+void ServiceWorkerGlobalScopeProxy::dispatchNotificationClickEvent(int eventID, const WebString& notificationID, const WebNotificationData& data, int actionIndex)

{

WaitUntilObserver* observer = WaitUntilObserver::create(workerGlobalScope(), WaitUntilObserver::NotificationClick, eventID);

NotificationEventInit eventInit;

@@ -208,7 +208,7 @@ void ServiceWorkerGlobalScopeProxy::dispatchNotificationClickEvent(int eventID,

workerGlobalScope()->dispatchExtendableEvent(event, observer);

}

-void ServiceWorkerGlobalScopeProxy::dispatchNotificationCloseEvent(int eventID, int64_t notificationID, const WebNotificationData& data)

+void ServiceWorkerGlobalScopeProxy::dispatchNotificationCloseEvent(int eventID, const WebString& notificationID, const WebNotificationData& data)

{

WaitUntilObserver* observer = WaitUntilObserver::create(workerGlobalScope(), WaitUntilObserver::NotificationClose, eventID);

NotificationEventInit eventInit;