Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)
Patch Set: rebase + comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/notifications/notification_database.cc ('K') | « content/common/platform_notification_messages.h ('k') | content/public/browser/BUILD.gn » ('j') | content/public/browser/notification_database_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/service_worker/service_worker_messages.h
diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h
index d41d517236e961f981ef51ef7bbdd583c7dc0e79..59af129dd12f5df863d18ace425eed15484abba0 100644
--- a/content/common/service_worker/service_worker_messages.h
+++ b/content/common/service_worker/service_worker_messages.h
@@ -497,12 +497,12 @@ IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_FetchEvent,
content::ServiceWorkerFetchRequest)
IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_NotificationClickEvent,
int /* request_id */,
- int64_t /* persistent_notification_id */,
+ std::string /* notification_id */,
content::PlatformNotificationData /* notification_data */,
int /* action_index */)
IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_NotificationCloseEvent,
int /* request_id */,
- int64_t /* persistent_notification_id */,
+ std::string /* notification_id */,
content::PlatformNotificationData /* notification_data */)
IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_PushEvent,
int /* request_id */,
« content/browser/notifications/notification_database.cc ('K') | « content/common/platform_notification_messages.h ('k') | content/public/browser/BUILD.gn » ('j') | content/public/browser/notification_database_data.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698