Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: content/browser/notifications/page_notification_delegate.h

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)
Patch Set: rebase + comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/page_notification_delegate.h
diff --git a/content/browser/notifications/page_notification_delegate.h b/content/browser/notifications/page_notification_delegate.h
index fd45f9152bc25b5e20eb3cab6c53afa77ab71a05..497255bad0a20b66e9d10e2bf2ee7d18c2875aa5 100644
--- a/content/browser/notifications/page_notification_delegate.h
+++ b/content/browser/notifications/page_notification_delegate.h
@@ -5,6 +5,8 @@
#ifndef CONTENT_BROWSER_NOTIFICATIONS_PAGE_NOTIFICATION_DELEGATE_H_
#define CONTENT_BROWSER_NOTIFICATIONS_PAGE_NOTIFICATION_DELEGATE_H_
+#include <string>
+
#include "content/public/browser/desktop_notification_delegate.h"
namespace content {
@@ -14,7 +16,9 @@ namespace content {
// that of the page displaying them.
class PageNotificationDelegate : public DesktopNotificationDelegate {
public:
- PageNotificationDelegate(int render_process_id, int notification_id);
+ PageNotificationDelegate(int render_process_id,
+ int non_persistent_notification_id,
+ const std::string& notification_id);
~PageNotificationDelegate() override;
// DesktopNotificationDelegate implementation.
@@ -24,7 +28,8 @@ class PageNotificationDelegate : public DesktopNotificationDelegate {
private:
int render_process_id_;
- int notification_id_;
+ int non_persistent_notification_id_;
+ std::string notification_id_;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698