Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: content/browser/notifications/notification_event_dispatcher_impl.h

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)
Patch Set: rebase + comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/notification_event_dispatcher_impl.h
diff --git a/content/browser/notifications/notification_event_dispatcher_impl.h b/content/browser/notifications/notification_event_dispatcher_impl.h
index fc19dc9ed77ed7c2aa9780de611a6bd6ab6b0b97..4c7f14d05d3d97eb629442e2f46fe2fccc12aa9e 100644
--- a/content/browser/notifications/notification_event_dispatcher_impl.h
+++ b/content/browser/notifications/notification_event_dispatcher_impl.h
@@ -5,8 +5,6 @@
#ifndef CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_
#define CONTENT_BROWSER_NOTIFICATIONS_NOTIFICATION_EVENT_DISPATCHER_IMPL_H_
-#include <stdint.h>
-
#include "base/macros.h"
#include "base/memory/singleton.h"
#include "content/public/browser/notification_database_data.h"
@@ -23,14 +21,14 @@ class NotificationEventDispatcherImpl : public NotificationEventDispatcher {
// NotificationEventDispatcher implementation.
void DispatchNotificationClickEvent(
BrowserContext* browser_context,
- int64_t persistent_notification_id,
+ const std::string& notification_id,
const GURL& origin,
int action_index,
const NotificationDispatchCompleteCallback& dispatch_complete_callback)
override;
void DispatchNotificationCloseEvent(
BrowserContext* browser_context,
- int64_t persistent_notification_id,
+ const std::string& notification_id,
const GURL& origin,
bool by_user,
const NotificationDispatchCompleteCallback& dispatch_complete_callback)

Powered by Google App Engine
This is Rietveld 408576698